Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete HammerAddons FGD tags support #99

Closed
vrad-exe opened this issue Mar 11, 2023 · 2 comments
Closed

Incomplete HammerAddons FGD tags support #99

vrad-exe opened this issue Mar 11, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@vrad-exe
Copy link

There currently seems to be some support for HammerAddons tags, but it's very limited. Single tags on keyvalues and I/O will be highlighted blue, but using multiple tags or inverted tags will cause the surrounding coloring to break.
image

For spawnflags and choices type keyvalues it's worse, adding the FGD tags at the end of the line will break coloring for the entire rest of the file past where the tag is located.
image

For reference, the full list of supported features can be found here

@StefanH-AT StefanH-AT added the bug Something isn't working label Mar 12, 2023
@StefanH-AT
Copy link
Owner

I've been wanting to rewrite the FGD syntax highlighting for a while since it was way too rigid and was easily broken. Just pushed an update that should fix the issues you mentioned. (0.10.3)

Let me know if there are any more problems. If there aren't, feel free to close!

@StefanH-AT StefanH-AT added this to the Release 1.0 milestone Mar 12, 2023
@vrad-exe
Copy link
Author

Seems to all be working as expected now! One more thing is you might want to change the parameters of the appliesto() helper to be colored dark blue since those are also FGD tags, but not doing that doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants