-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Enhancement] Full sort use german string for comparison #62929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
be/src/column/german_string.h
Outdated
}; | ||
|
||
using Bytes = starrocks::raw::RawVectorPad16<uint8_t, ColumnAllocator<uint8_t>>; | ||
class GermanStringBinaryColumnExternalAllocator : public GermanStringExternalAllocator { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems unused ?
return os; | ||
} | ||
union { | ||
uint32_t len; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this len is not necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no overhead
3769f98
to
a4fbc96
Compare
a4fbc96
to
fd2bf2a
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 2 / 5 (40.00%) file detail
|
Signed-off-by: satanson <[email protected]>
fd2bf2a
to
42d38c8
Compare
|
Why I'm doing:
Full sort using german string for comparison can accelerate queries if the string-type order-by column has different prefix 4 bytes.
use sv enable_full_sort_use_german_string to control this behavior, it is false in default.
for queries constructed on click_bench as follows
The test result

Performances of Q2, Q5, Q7 decrease significantly since the order-by column URL and Referer are almost the same.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: