Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm: Report fragmentation statistics #1784

Open
manopapad opened this issue Oct 29, 2024 · 2 comments
Open

Realm: Report fragmentation statistics #1784

manopapad opened this issue Oct 29, 2024 · 2 comments
Milestone

Comments

@manopapad
Copy link
Contributor

Currently on OOM we can print out the base pointers from instances, plus their sizes, to inspect the use of the memory space, to check if fragmentation is an issue. However, this is not complete because Realm doesn't expose the base pointer of the memory (presumably because this doesn't make sense for all memories).

An alternative that has been floated is to have Realm report stats on fragmentation. I don't know the full set of stats that might be useful to report, but one that would certainly help is to report the largest "hole", so the user knows what is the max allocation that could have succeeded.

@lightsighter
Copy link
Contributor

I feel like we could do this pretty easily by an additional field to the InstanceAllocResult profiling response that would report the size of the largest hole that could be satisfied if success=false.
https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/realm/profiling.h?ref_type=heads#L249-253

@apryakhin apryakhin added this to the realm-backlog milestone Oct 30, 2024
@apryakhin
Copy link
Contributor

apryakhin commented Nov 1, 2024

I put the "reporting" in the backlog for now as it's behind "other items" that we planned to do first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants