Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mistral from the launch_dev.sh script #5012

Closed
punkrokk opened this issue Aug 4, 2020 · 4 comments · Fixed by #5011
Closed

Remove mistral from the launch_dev.sh script #5012

punkrokk opened this issue Aug 4, 2020 · 4 comments · Fixed by #5011
Milestone

Comments

@punkrokk
Copy link
Member

punkrokk commented Aug 4, 2020

The launch_dev.sh script has funtionality that needs to get removed so it doesn't try to spin up mistral things

@punkrokk punkrokk added this to the 3.3.0 milestone Aug 4, 2020
@arm4b arm4b mentioned this issue Aug 4, 2020
25 tasks
@amanda11
Copy link
Contributor

amanda11 commented Aug 4, 2020

Is this not part of all of the mistral bits of st2 that get removed, or does this need to be done separately, earlier etc?

I can split it out of the PR I'm working on to remove mistral from st2 repo, if we want it earlier and if it can be done separately.

@arm4b
Copy link
Member

arm4b commented Aug 5, 2020

There is no need of separation so far. Launchdev script is just one of the places to touch.

@punkrokk
Copy link
Member Author

punkrokk commented Aug 5, 2020 via email

@amanda11
Copy link
Contributor

amanda11 commented Aug 5, 2020

I will update my pr so it references this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants