From eba62ddfb6f5d6b1b4d9b8ca7949bd233ecb1777 Mon Sep 17 00:00:00 2001
From: Jacob Floyd <cognifloyd@gmail.com>
Date: Wed, 30 Nov 2022 08:12:39 -0600
Subject: [PATCH] Update to pants 2.14 (final) (#5817)

* pants: silence un-actionable unowned dep warnings

* bump to pants 2.14.0

* update changelog entry
---
 CHANGELOG.rst |  2 +-
 pants.toml    | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e7b64c505d..5b1aecb27e 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -10,7 +10,7 @@ Added
 * Continue introducing `pants <https://www.pantsbuild.org/docs>`_ to improve DX (Developer Experience)
   working on StackStorm, improve our security posture, and improve CI reliability thanks in part
   to pants' use of PEX lockfiles. This is not a user-facing addition.
-  #5778 #5789
+  #5778 #5789 #5817
   Contributed by @cognifloyd
 
 
diff --git a/pants.toml b/pants.toml
index 3ddbf7b88f..a0d10cac67 100644
--- a/pants.toml
+++ b/pants.toml
@@ -6,7 +6,7 @@ enabled = false
 repo_id = "de0dea7a-9f6a-4c6e-aa20-6ba5ad969b8a"
 
 [GLOBAL]
-pants_version = "2.14.0rc3"
+pants_version = "2.14.0"
 backend_packages = [
   # python
   "pants.backend.python",
@@ -84,6 +84,16 @@ root_patterns = [
   "/st2common/benchmarks/micro",
 ]
 
+[python-infer]
+# https://www.pantsbuild.org/docs/reference-python-infer#unowned_dependency_behavior
+# The default changed from "ignore" to "warning" in pants 2.14.
+# Many of the new warnings however have been adressed via explicit deps,
+# so the warnings are not helpful. In pants 2.16, a "visibility" feature might help
+# us to disambiguate deps between files without those explicit BUILD dependencies,
+# and without adding "# pants: no-infer-dep" comments all over the codebase.
+# Revisit this in pants 2.16 to see if it is feasible to use the default "warning".
+unowned_dependency_behavior = "ignore"
+
 [bandit]
 lockfile = "lockfiles/bandit.lock"
 version = "bandit==1.7.0"