From b06f644a2db3b8acbf392ea8d15904384fbc7f63 Mon Sep 17 00:00:00 2001 From: Marc Gravell Date: Wed, 16 Jul 2025 15:51:07 +0100 Subject: [PATCH 1/3] Fix CLIENT ID error during handshake --- docs/ReleaseNotes.md | 1 + src/StackExchange.Redis/ResultProcessor.cs | 3 +++ tests/StackExchange.Redis.Tests/ConfigTests.cs | 1 + 3 files changed, 5 insertions(+) diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md index b182284f0..ae3f03788 100644 --- a/docs/ReleaseNotes.md +++ b/docs/ReleaseNotes.md @@ -10,6 +10,7 @@ Current package versions: - Add support for new `BITOP` operations in CE 8.2 ([#2900 by atakavci](https://github.com/StackExchange/StackExchange.Redis/pull/2900)) - Package updates ([#2906 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2906)) +- Fix handshake error connecting to RESP2 servers ## 2.8.41 diff --git a/src/StackExchange.Redis/ResultProcessor.cs b/src/StackExchange.Redis/ResultProcessor.cs index 03e0a8577..06647212b 100644 --- a/src/StackExchange.Redis/ResultProcessor.cs +++ b/src/StackExchange.Redis/ResultProcessor.cs @@ -831,6 +831,9 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes { connection.ConnectionId = clientId; Log?.LogInformation($"{Format.ToString(server)}: Auto-configured (CLIENT) connection-id: {clientId}"); + + SetResult(message, true); + return true; } } break; diff --git a/tests/StackExchange.Redis.Tests/ConfigTests.cs b/tests/StackExchange.Redis.Tests/ConfigTests.cs index c8a5eacd6..7c8e917b7 100644 --- a/tests/StackExchange.Redis.Tests/ConfigTests.cs +++ b/tests/StackExchange.Redis.Tests/ConfigTests.cs @@ -472,6 +472,7 @@ public void GetClients() if (server.Features.ClientId) { var id = conn.GetConnectionId(server.EndPoint, ConnectionType.Interactive); + Log("client id: " + id); Assert.NotNull(id); Assert.True(clients.Any(x => x.Id == id), "expected: " + id); id = conn.GetConnectionId(server.EndPoint, ConnectionType.Subscription); From 2b4e54755ac75035fd06fde63fa9d58b8ca0254d Mon Sep 17 00:00:00 2001 From: Marc Gravell Date: Thu, 17 Jul 2025 10:08:52 +0100 Subject: [PATCH 2/3] update release notes --- docs/ReleaseNotes.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md index ae3f03788..f9711b2ca 100644 --- a/docs/ReleaseNotes.md +++ b/docs/ReleaseNotes.md @@ -9,8 +9,8 @@ Current package versions: ## Unreleased - Add support for new `BITOP` operations in CE 8.2 ([#2900 by atakavci](https://github.com/StackExchange/StackExchange.Redis/pull/2900)) -- Package updates ([#2906 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2906)) -- Fix handshake error connecting to RESP2 servers +- Package updates ([#2906 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2906))~~~~ +- Fix handshake error with `CLIENT ID` ([#2909 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2909)) ## 2.8.41 From 2d61fca06bd050a40b41b61715d54c25f2c90587 Mon Sep 17 00:00:00 2001 From: Marc Gravell Date: Thu, 17 Jul 2025 10:10:19 +0100 Subject: [PATCH 3/3] tilde --- docs/ReleaseNotes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md index f9711b2ca..b3a788286 100644 --- a/docs/ReleaseNotes.md +++ b/docs/ReleaseNotes.md @@ -9,7 +9,7 @@ Current package versions: ## Unreleased - Add support for new `BITOP` operations in CE 8.2 ([#2900 by atakavci](https://github.com/StackExchange/StackExchange.Redis/pull/2900)) -- Package updates ([#2906 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2906))~~~~ +- Package updates ([#2906 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2906)) - Fix handshake error with `CLIENT ID` ([#2909 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2909)) ## 2.8.41