Convert to Hex only on Encoding.UTF8.GetString possible exceptions (#2954)

* Convert to Hex only on Encoding.UTF8.GetString possible exception
Has OutOfMemory exceptions can occure in native Encoding.UTF8.GetString, we should not convert result to hex values

* Fix other cases where we return an Hex string on all kind of exceptions

Author: jcaspes

src/StackExchange.Redis/RedisChannel.cs

@@ -302,9 +302,12 @@ public static implicit operator RedisChannel(byte[]? key)
             {
                 return Encoding.UTF8.GetString(arr);
             }
-            catch
+            catch (Exception e) when // Only catch exception throwed by Encoding.UTF8.GetString
+                (e is DecoderFallbackException
+                || e is ArgumentException
+                || e is ArgumentNullException)
             {
-                return BitConverter.ToString(arr);
+                    return BitConverter.ToString(arr);
             }
         }
 

src/StackExchange.Redis/RedisKey.cs

@@ -299,9 +299,12 @@ public static implicit operator RedisKey(byte[]? key)
                 {
                     return Encoding.UTF8.GetString(arr, 0, length);
                 }
-                catch
+                catch (Exception e) when // Only catch exception throwed by Encoding.UTF8.GetString
+                    (e is DecoderFallbackException
+                    || e is ArgumentException
+                    || e is ArgumentNullException)
                 {
-                    return BitConverter.ToString(arr, 0, length);
+                        return BitConverter.ToString(arr, 0, length);
                 }
             }
         }

src/StackExchange.Redis/RedisValue.cs

@@ -789,7 +789,10 @@ private static bool TryParseDouble(ReadOnlySpan<byte> blob, out double value)
                     {
                         return Format.GetString(span);
                     }
-                    catch
+                    catch (Exception e) when // Only catch exception throwed by Encoding.UTF8.GetString
+                        (e is DecoderFallbackException
+                        || e is ArgumentException
+                        || e is ArgumentNullException)
                     {
                         return ToHex(span);
                     }