Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codesigning error, it is trying to sign a binary file that is splitted in parts #1831

Open
augustnmonteiro opened this issue Sep 16, 2022 · 1 comment

Comments

@augustnmonteiro
Copy link

Squirrel version(s)
2.0.1

Description
I'm using a lib that divides it's binary file into 3 files, the first one gets signed fine, the 2,3 files it seems like that it doesn't get signed because of the mime type, could we check if the mime type is valid before sending it to the signtool?

Steps to recreate

  1. start electron project with electron-forge
  2. add nut.js https://github.com/nut-tree/nut.js
  3. make the project with a certificate configuration

Expected behavior
Sign only files that can be signed

Actual behavior
It is trying to sign the whole folder

Additional information
for reference the lib we are using it is https://github.com/nut-tree/libnut

@anaisbetts
Copy link
Contributor

anaisbetts commented Sep 17, 2022

Squirrel doesn't care about or use MIME types, it would be helpful if you could describe how this library works in more detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants