JAVA-12359 Code Review Changes

Author: anuragkumawat

core-java-modules/core-java-string-operations-3/src/main/java/com/baeldung/stringfilenamevalidaiton/StringFilenameValidationUtils.java

@@ -7,7 +7,7 @@
 
 public class StringFilenameValidationUtils {
 
-    public static final Character[] INVALID_WINDOWS_SPECIFIC_CHARS = {'"', '*', ':', '<', '>', '?', '\\', '|'};
+    public static final Character[] INVALID_WINDOWS_SPECIFIC_CHARS = {'"', '*', '<', '>', '?', '|'};
     public static final Character[] INVALID_UNIX_SPECIFIC_CHARS = {'\000'};
 
     public static final String REGEX_PATTERN = "^[A-za-z0-9.]{1,255}$";

core-java-modules/core-java-string-operations-3/src/test/java/com/baeldung/stringfilenamevalidaiton/StringFilenameValidationUnitTest.java

@@ -82,16 +82,12 @@ public void givenFilenameStringWithInvalidWindowsCharAndIsUnix_whenValidateUsing
     @MethodSource("filenamesWithInvalidWindowsChars")
 	public void givenFilenameStringWithInvalidWindowsCharAndIsWindows_whenValidateUsingIO_thenRaiseException(
 			String filename) {
-		if (!filename.contains(":")) {
-			assertThatThrownBy(() -> validateStringFilenameUsingIO(filename)).isInstanceOf(IOException.class)
-					.extracting(Throwable::getMessage, InstanceOfAssertFactories.STRING)
-					.containsAnyOf("The system cannot find the path specifie",
-							"The filename, directory name, or volume label syntax is incorrect");
-			if (!filename.contains("\\")) {
-				assertThatThrownBy(() -> validateStringFilenameUsingNIO2(filename))
-						.isInstanceOf(InvalidPathException.class).hasMessageContaining("Illegal char");
-			}
-		}
+		assertThatThrownBy(() -> validateStringFilenameUsingIO(filename)).isInstanceOf(IOException.class)
+				.extracting(Throwable::getMessage, InstanceOfAssertFactories.STRING)
+				.containsAnyOf("The system cannot find the path specified",
+						"The filename, directory name, or volume label syntax is incorrect");
+		assertThatThrownBy(() -> validateStringFilenameUsingNIO2(filename)).isInstanceOf(InvalidPathException.class)
+				.hasMessageContaining("Illegal char");
 
 		assertThat(validateStringFilenameUsingContains(filename)).isFalse();
 	}