Skip to content

Commit 3252beb

Browse files
authored
JAVA-7133: POM Properties Cleanup (eugenp#11229)
* JAVA-7133: Use common org.slf4j.version property * JAVA-7133: Use common logback.version property
1 parent 45146b9 commit 3252beb

File tree

17 files changed

+12
-34
lines changed

17 files changed

+12
-34
lines changed

apache-libraries/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@
201201
<maven.compiler.source>1.8</maven.compiler.source>
202202
<maven.compiler.target>1.8</maven.compiler.target>
203203
<avro.version>1.8.2</avro.version>
204-
<slf4j.version>1.7.25</slf4j.version>
205204
<beam.version>2.19.0</beam.version>
206205
<assertj.version>3.9.0</assertj.version>
207206
<bval.version>1.1.2</bval.version>

apache-thrift/pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<dependency>
3030
<groupId>org.slf4j</groupId>
3131
<artifactId>slf4j-simple</artifactId>
32-
<version>${org.slf4j.slf4j-simple.version}</version>
32+
<version>${org.slf4j.version}</version>
3333
<scope>test</scope>
3434
</dependency>
3535
</dependencies>
@@ -61,7 +61,6 @@
6161
<properties>
6262
<thrift.version>0.10.0</thrift.version>
6363
<maven-thrift.version>0.1.11</maven-thrift.version>
64-
<org.slf4j.slf4j-simple.version>1.7.12</org.slf4j.slf4j-simple.version>
6564
<build-helper-maven-plugin.version>3.0.0</build-helper-maven-plugin.version>
6665
</properties>
6766

core-groovy-2/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@
166166
<hsqldb.version>2.4.0</hsqldb.version>
167167
<spock-core.version>1.1-groovy-2.4</spock-core.version>
168168
<groovy-wslite.version>1.1.3</groovy-wslite.version>
169-
<logback.version>1.2.3</logback.version>
170169
<groovy.version>2.5.7</groovy.version>
171170
<assembly.plugin.version>3.1.0</assembly.plugin.version>
172171
<compiler.plugin.version>3.8.0</compiler.plugin.version>

deeplearning4j/pom.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@
3939
<dependency>
4040
<groupId>org.slf4j</groupId>
4141
<artifactId>slf4j-api</artifactId>
42-
<version>${slf4j.version}</version>
42+
<version>${org.slf4j.version}</version>
4343
</dependency>
4444
<dependency>
4545
<groupId>org.slf4j</groupId>
4646
<artifactId>slf4j-log4j12</artifactId>
47-
<version>${slf4j.version}</version>
47+
<version>${org.slf4j.version}</version>
4848
</dependency>
4949
<!-- https://mvnrepository.com/artifact/org.datavec/datavec-api -->
5050
<dependency>
@@ -62,7 +62,6 @@
6262
<properties>
6363
<dl4j.version>0.9.1</dl4j.version> <!-- Latest non beta version -->
6464
<httpclient.version>4.3.5</httpclient.version>
65-
<slf4j.version>1.7.5</slf4j.version>
6665
</properties>
6766

6867
</project>

ethereum/pom.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
<dependency>
100100
<groupId>org.slf4j</groupId>
101101
<artifactId>jcl-over-slf4j</artifactId>
102-
<version>${slf4j.version}</version>
102+
<version>${org.slf4j.version}</version>
103103
</dependency>
104104
<dependency>
105105
<groupId>ch.qos.logback</groupId>
@@ -204,8 +204,6 @@
204204
<spring.boot.version>1.5.6.RELEASE</spring.boot.version>
205205
<mockito.version>2.21.0</mockito.version>
206206
<jsonpath.version>2.4.0</jsonpath.version>
207-
<logback.version>1.2.3</logback.version>
208-
<slf4j.version>1.7.25</slf4j.version>
209207
<spring-boot-maven-plugin.version>2.0.4.RELEASE</spring-boot-maven-plugin.version>
210208
<compiler.plugin.version>3.1</compiler.plugin.version>
211209
</properties>

libraries-data-2/pom.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,12 @@
104104
<dependency>
105105
<groupId>org.slf4j</groupId>
106106
<artifactId>slf4j-api</artifactId>
107-
<version>${slf4j.version}</version>
107+
<version>${org.slf4j.version}</version>
108108
</dependency>
109109
<dependency>
110110
<groupId>org.slf4j</groupId>
111111
<artifactId>slf4j-log4j12</artifactId>
112-
<version>${slf4j.version}</version>
112+
<version>${org.slf4j.version}</version>
113113
</dependency>
114114
<dependency>
115115
<groupId>com.univocity</groupId>
@@ -161,7 +161,6 @@
161161
<suanshu.version>4.0.0</suanshu.version>
162162
<derive4j.version>1.1.0</derive4j.version>
163163
<assertj.version>3.6.2</assertj.version>
164-
<slf4j.version>1.7.25</slf4j.version>
165164
<awaitility.version>3.0.0</awaitility.version>
166165
<univocity.version>2.8.4</univocity.version>
167166
<guava.version>29.0-jre</guava.version>

libraries-data/pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
<dependency>
109109
<groupId>org.slf4j</groupId>
110110
<artifactId>slf4j-api</artifactId>
111-
<version>${slf4j.version}</version>
111+
<version>${org.slf4j.version}</version>
112112
</dependency>
113113
<dependency>
114114
<groupId>org.apache.storm</groupId>
@@ -173,7 +173,6 @@
173173
<hazelcast.version>3.8.4</hazelcast.version>
174174
<org.apache.crunch.crunch-core.version>0.15.0</org.apache.crunch.crunch-core.version>
175175
<org.apache.hadoop.hadoop-client>2.2.0</org.apache.hadoop.hadoop-client>
176-
<slf4j.version>1.7.25</slf4j.version>
177176
<jmapper.version>1.6.0.1</jmapper.version>
178177
</properties>
179178

logging-modules/logback/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
</dependencies>
7070

7171
<properties>
72-
<logback.version>1.2.3</logback.version>
7372
<logback.contrib.version>0.1.5</logback.contrib.version>
7473
<docx4j.version>3.3.5</docx4j.version>
7574
<javax.mail.version>1.4.7</javax.mail.version>

micronaut/pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<dependency>
6262
<groupId>ch.qos.logback</groupId>
6363
<artifactId>logback-classic</artifactId>
64-
<version>${lombok.version}</version>
64+
<version>${logback.version}</version>
6565
<scope>runtime</scope>
6666
</dependency>
6767
<dependency>
@@ -145,7 +145,6 @@
145145
<micronaut.version>1.0.0.RC2</micronaut.version>
146146
<jdk.version>1.8</jdk.version>
147147
<annotation.api.version>1.3.2</annotation.api.version>
148-
<lombok.version>1.2.3</lombok.version>
149148
<reactor.version>3.1.6.RELEASE</reactor.version>
150149
<compiler.plugin.version>3.7.0</compiler.plugin.version>
151150
<shade.plugin.version>3.1.0</shade.plugin.version>

persistence-modules/hibernate-libraries/pom.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
<dependency>
7878
<groupId>org.slf4j</groupId>
7979
<artifactId>slf4j-api</artifactId>
80-
<version>${slf4j.version}</version>
80+
<version>${org.slf4j.version}</version>
8181
<scope>provided</scope>
8282
<optional>true</optional>
8383
</dependency>
@@ -174,12 +174,10 @@
174174
<javassist.version>3.27.0-GA</javassist.version>
175175
<jaxb.version>2.3.1</jaxb.version>
176176
<log4jdbc.version>2.0.0</log4jdbc.version>
177-
<logback.version>1.2.3</logback.version>
178177
<maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
179178
<maven.compiler.version>3.8.1</maven.compiler.version>
180179
<maven.version>3.8.1</maven.version>
181180
<mysql.version>8.0.19</mysql.version>
182-
<slf4j.version>1.7.30</slf4j.version>
183181
<spring-boot.version>2.1.3.RELEASE</spring-boot.version>
184182
</properties>
185183

0 commit comments

Comments
 (0)