Fix eslint warnings

Author: Kirill Kaiumov

.eslintrc

@@ -11,6 +11,8 @@ globals:
   Raphael: true
   SpreeAPI: true
   SpreePaths: true
+  CouponManager: true
+  ThumbnailsCarousel: true
 
 env:
   browser: true

frontend/app/assets/javascripts/spree/frontend/cart.js

@@ -11,7 +11,7 @@ Spree.ready(function ($) {
     $('form#update-cart input.shopping-cart-item-quantity-input').on('keyup', function(e) {
       var itemId = $(this).attr('data-id')
       var value = $(this).val()
-      var newValue = isNaN(value) || value === "" ? value : parseInt(value, 10)
+      var newValue = isNaN(value) || value === '' ? value : parseInt(value, 10)
       var targetInputs = $("form#update-cart input.shopping-cart-item-quantity-input[data-id='" + itemId + "']")
       $(targetInputs).val(newValue)
     })

frontend/app/assets/javascripts/spree/frontend/checkout.js

@@ -37,8 +37,8 @@ Spree.ready(function () {
       } else {
         return false
       }
-
     })
+
     $('form#checkout_form_confirm button#shopping-cart-remove-coupon-code-button').off('click').on('click', function(event) {
       var input = {
         appliedCouponCodeField: $('#order_applied_coupon_code'),

frontend/app/assets/javascripts/spree/frontend/product.js

@@ -3,7 +3,6 @@
 
 Spree.ready(function($) {
   $('body').on('product_add_to_cart', function(event) {
-
     Spree.showProductAddedModal(event.product, event.variant)
   })
 })

frontend/app/assets/javascripts/spree/frontend/views/spree/products/cart_form.js

@@ -264,7 +264,7 @@ Spree.ready(function($) {
             cart: response.attributes
           })
         },
-        function(error) {
+        function(_error) {
           document.getElementById('overlay').classList.add('shown')
           document.getElementById('no-product-available').classList.add('shown')
           window.scrollTo(0, 0)
@@ -277,6 +277,6 @@ Spree.ready(function($) {
   $(ADD_TO_CART_FORM_SELECTOR).each(function(_cartFormIndex, cartFormElement) {
     var $cartForm = $(cartFormElement)
 
-    new CartForm($, $cartForm)
+    CartForm($, $cartForm)
   })
 })

frontend/app/assets/javascripts/spree/frontend/views/spree/products/description.js

@@ -1,8 +1,8 @@
 $(function() {
-  $('#product-description-arrow').click(function() { 
-    document.getElementById('product-description-long').classList.remove('d-none') 
-    document.getElementById('product-description-short').classList.add('d-none') 
-    document.getElementById('product-description-arrow').classList.remove('d-flex') 
-    document.getElementById('product-description-arrow').classList.add('d-none') 
+  $('#product-description-arrow').click(function() {
+    document.getElementById('product-description-long').classList.remove('d-none')
+    document.getElementById('product-description-short').classList.add('d-none')
+    document.getElementById('product-description-arrow').classList.remove('d-flex')
+    document.getElementById('product-description-arrow').classList.add('d-none')
   })
 })

frontend/app/assets/javascripts/spree/frontend/views/spree/products/modal_carousel.js

@@ -1,6 +1,6 @@
 Spree.ready(function($) {
   var $modalCarousel = $('#productModalThumbnailsCarousel')
-  new ThumbnailsCarousel($, $modalCarousel)
+  ThumbnailsCarousel($, $modalCarousel)
 
   var activeSingleImageIndex = function(sourceWrappingClass) {
     var $activeSingleImage = $('.' + sourceWrappingClass + ' .product-details-single [data-variant-id].active')

frontend/app/assets/javascripts/spree/frontend/views/spree/shared/carousel/thumbnails.js

@@ -130,5 +130,5 @@ Spree.ready(function($) {
 
   var $carousel = $('#productThumbnailsCarousel')
 
-  new ThumbnailsCarousel($, $carousel)
+  ThumbnailsCarousel($, $carousel)
 })

frontend/app/assets/javascripts/spree/frontend/views/spree/shared/delete_address_popup.js

@@ -1,23 +1,27 @@
 Spree.ready(function($) {
   var deleteAddressLinks = document.querySelectorAll('.js-delete-address-link');
-  if (deleteAddressLinks.length > 0) deleteAddressLinks.forEach(function(deleteLink) {
-    deleteLink.addEventListener('click', function(e) {
-      document.querySelector('#overlay').classList.add('shown');
-      document.querySelector('#delete-address-popup').classList.add('shown');
-      document.querySelector('#delete-address-popup-confirm').href = e.currentTarget.dataset.address;
-    }, false)
-  })
+  if (deleteAddressLinks.length > 0) {
+    deleteAddressLinks.forEach(function(deleteLink) {
+      deleteLink.addEventListener('click', function(e) {
+        document.querySelector('#overlay').classList.add('shown');
+        document.querySelector('#delete-address-popup').classList.add('shown');
+        document.querySelector('#delete-address-popup-confirm').href = e.currentTarget.dataset.address;
+      }, false)
+    })
+  }
 
   document.querySelector('#overlay').addEventListener('click', function () {
     var addressActionElement = document.querySelector('#delete-address-popup');
     if (addressActionElement) addressActionElement.classList.remove('shown');
   }, false);
 
   var popupCloseButtons = document.querySelectorAll('.js-delete-address-popup-close-button')
-  if (popupCloseButtons.length > 0) popupCloseButtons.forEach(function(closeButton) {
-    closeButton.addEventListener('click', function(e) {
-      document.querySelector('#overlay').classList.remove('shown');
-      document.querySelector('#delete-address-popup').classList.remove('shown');
+  if (popupCloseButtons.length > 0) {
+    popupCloseButtons.forEach(function(closeButton) {
+      closeButton.addEventListener('click', function(e) {
+        document.querySelector('#overlay').classList.remove('shown');
+        document.querySelector('#delete-address-popup').classList.remove('shown');
+      })
     })
-  })
+  }
 })