Skip to content

Commit 4daad99

Browse files
Drop versioncake dependency
versioncake doesn't support Rails 6 and isn't actively maintained. For API v2 we've used serializers and we won't be using versioned views in the future.
1 parent b8b81c2 commit 4daad99

File tree

101 files changed

+0
-27
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+0
-27
lines changed

.gitignore

-2
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,8 @@ public/google_base.xml
4343
public/template_google_base.xml
4444
coverage/*
4545
var
46-
TAGS
4746
nbproject
4847
./vendor
49-
tags
5048
*.swp
5149
rerun.txt
5250
test_app

api/config/initializers/metal_load_paths.rb

-1
This file was deleted.

api/lib/spree/api/engine.rb

-12
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require 'rails/engine'
2-
require 'versioncake'
32

43
module Spree
54
module Api
@@ -17,17 +16,6 @@ class Engine < Rails::Engine
1716
config.json_engine = ActiveSupport::JSON
1817
end
1918

20-
initializer 'spree.api.versioncake' do |_app|
21-
VersionCake.setup do |config|
22-
config.resources do |r|
23-
r.resource %r{.*}, [], [], [1, 2]
24-
end
25-
26-
config.missing_version = 1
27-
config.extraction_strategy = :http_header
28-
end
29-
end
30-
3119
# sets the manifests / assets to be precompiled, even when initialize_on_precompile is false
3220
initializer 'spree.assets.precompile', group: :all do |app|
3321
app.config.assets.precompile += %w[

api/lib/spree_api.rb

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require 'spree/api'
22
require 'spree/api/responders'
3-
require 'versioncake'
43
require 'fast_jsonapi'
54
require 'doorkeeper'

api/spec/spec_helper.rb

-5
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@
6363
Spree::Api::Config[:requires_authentication] = true
6464
end
6565

66-
config.include VersionCake::TestHelpers, type: :controller
67-
config.before(:each, type: :controller) do
68-
set_request_version('', 1)
69-
end
70-
7166
config.order = :random
7267
Kernel.srand config.seed
7368
end

api/spree_api.gemspec

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ Gem::Specification.new do |s|
2121

2222
s.add_dependency 'spree_core', s.version
2323
s.add_dependency 'rabl', '~> 0.13.1'
24-
s.add_dependency 'versioncake', '~> 3.4.0'
2524
s.add_dependency 'fast_jsonapi', '~> 1.5'
2625
s.add_dependency 'doorkeeper', '~> 5.0'
2726
end

backend/spec/spec_helper.rb

-5
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,6 @@
109109

110110
config.include Spree::Core::ControllerHelpers::StrongParameters, type: :controller
111111

112-
config.include VersionCake::TestHelpers, type: :controller
113-
config.before(:each, type: :controller) do
114-
set_request_version('', 1)
115-
end
116-
117112
config.verbose_retry = true
118113
config.display_try_failure_messages = true
119114

0 commit comments

Comments
 (0)