Run rubocop -a in core/spec

Author: artplan1

.rubocop-disabled.yml

@@ -35,3 +35,15 @@ RSpec/MultipleExpectations:
 
 RSpec/FilePath:
   Enabled: false
+
+RSpec/LetSetup:
+  Enabled: false
+
+RSpec/SubjectStub:
+  Enabled: false
+
+RSpec/VoidExpect:
+  Enabled: false
+
+RSpec/BeforeAfterAll:
+  Enabled: false

.rubocop.yml

@@ -35,8 +35,10 @@ ModuleLength:
 Documentation:
   Enabled: false
 
-LineLength:
+Metrics/LineLength:
   Max: 150
+  Exclude:
+    - '**/spec/**/*'
 
 MethodLength:
   CountComments: false

api/spec/controllers/spree/api/v1/payments_controller_spec.rb

@@ -105,7 +105,7 @@ module Spree
             it 'can update' do
               payment.update_attributes(state: 'checkout')
               api_put(:update, id: payment.to_param, payment: { amount: 2.01 })
-              expect(response.status).to be(200)
+              expect(response.status).to eq(200)
               expect(payment.reload.amount).to eq(2.01)
             end
           end

api/spec/controllers/spree/api/v1/stores_controller_spec.rb

@@ -19,8 +19,7 @@ module Spree
         create(:store,
                name: 'Extra Store',
                url: 'spreestore-5.example.com',
-               default: false
-              )
+               default: false)
       end
 
       it 'I can list the available stores' do

api/spec/controllers/spree/api/v1/taxons_controller_spec.rb

@@ -58,6 +58,7 @@ module Spree
 
           context 'searching for top level taxon' do
             let(:name) { 'Ruby' }
+
             it 'returns the matching taxons' do
               expect_single_taxon_result 'Ruby'
             end

api/spec/controllers/spree/api/v1/unauthenticated_products_controller_spec.rb

@@ -5,7 +5,7 @@ module Spree
   describe Api::V1::ProductsController, type: :controller do
     render_views
 
-    let!(:product) { create(:product) } # rubocop:disable RSpec/LetSetup
+    let!(:product) { create(:product) }
     let(:attributes) { [:id, :name, :description, :price, :available_on, :slug, :meta_description, :meta_keywords, :taxon_ids] }
 
     context 'without authentication' do

api/spec/controllers/spree/api/v1/users_controller_spec.rb

@@ -87,7 +87,7 @@ module Spree
         assert_not_found!
       end
 
-      it 'onlies get own details on index' do
+      it 'only gets own details on index' do
         2.times { create(:user) }
         api_get :index, token: user.spree_api_key
 

api/spec/controllers/spree/api/v1/variants_controller_spec.rb

@@ -22,9 +22,9 @@ module Spree
 
     describe '#variant_includes' do
       let(:variants_includes_list) do
-        [{ option_values: :option_type }, :product,
-          :default_price, :images, { stock_items: :stock_location }]
+        [{ option_values: :option_type }, :product, :default_price, :images, { stock_items: :stock_location }]
       end
+
       it { expect(controller).to receive(:variant_includes).and_return(variants_includes_list) }
       after { api_get :index }
     end

backend/spec/controllers/spree/admin/resource_controller_spec.rb

@@ -15,7 +15,7 @@ def model_class
 describe Spree::Admin::DummyModelsController, type: :controller do
   stub_authorization!
 
-  after(:all) do # rubocop:disable RSpec/BeforeAfterAll
+  after(:all) do
     Rails.application.reload_routes!
   end
 

backend/spec/features/admin/configuration/states_spec.rb

@@ -18,7 +18,7 @@ def go_to_states_page
   context 'admin visiting states listing' do
     let!(:state) { create(:state, country: country) }
 
-    it 'correctlies display the states' do
+    it 'correctly displays the states' do
       visit spree.admin_country_states_path(country)
       expect(page).to have_content(state.name)
     end

backend/spec/features/admin/orders/payments_spec.rb

@@ -28,7 +28,7 @@ def refresh_page
     context 'with a check payment' do
       let(:order) { create(:completed_order_with_totals, number: 'R100') }
 
-      let!(:payment) do # rubocop:disable RSpec/LetSetup
+      let!(:payment) do
         create(:payment,
                order: order,
                amount: order.outstanding_balance,
@@ -211,7 +211,7 @@ def refresh_page
     end
 
     context 'with a check' do
-      let!(:payment_method) { create(:check_payment_method) }  # rubocop:disable RSpec/LetSetup
+      let!(:payment_method) { create(:check_payment_method) }
 
       before do
         visit spree.admin_order_payments_path(order.reload)

backend/spec/features/admin/products/products_spec.rb

@@ -410,7 +410,7 @@ def build_option_type_with_values(name, values)
     end
     let!(:product) { create(:product) }
 
-    it 'onlies display accessible links on index' do
+    it 'only displays accessible links on index' do
       visit spree.admin_products_path
 
       expect(page).to have_link('Products')
@@ -423,7 +423,7 @@ def build_option_type_with_values(name, values)
       expect(page).not_to have_css('.delete-resource')
     end
 
-    it 'onlies display accessible links on edit' do
+    it 'only displays accessible links on edit' do
       visit spree.admin_product_path(product)
 
       # product tabs should be hidden

core/spec/helpers/base_helper_spec.rb

@@ -53,17 +53,18 @@
   # Regression test for #1436
   context 'defining custom image helpers' do
     let(:product) { mock_model(Spree::Product, images: [], variant_images: []) }
+
     before do
       Spree::Image.class_eval do
         attachment_definitions[:attachment][:styles].merge!(very_strange: '1x1')
       end
     end
 
-    it 'should not raise errors when style exists' do
+    it 'does not raise errors when style exists' do
       expect { very_strange_image(product) }.not_to raise_error
     end
 
-    it 'should raise NoMethodError when style is not exists' do
+    it 'raises NoMethodError when style is not exists' do
       expect { another_strange_image(product) }.to raise_error(NoMethodError)
     end
   end
@@ -114,24 +115,25 @@ def link_to_tracking_html(options = {})
   # Regression test for #5384
   context 'custom image helpers conflict with inproper statements' do
     let(:product) { mock_model(Spree::Product, images: [], variant_images: []) }
+
     before do
       Spree::Image.class_eval do
         attachment_definitions[:attachment][:styles].merge!(foobar: '1x1')
       end
     end
 
-    it 'should not raise errors when helper method called' do
+    it 'does not raise errors when helper method called' do
       expect { foobar_image(product) }.not_to raise_error
     end
 
-    it 'should raise NoMethodError when statement with name equal to style name called' do
+    it 'raises NoMethodError when statement with name equal to style name called' do
       expect { foobar(product) }.to raise_error(NoMethodError)
     end
   end
 
   context 'pretty_time' do
     it 'prints in a format' do
-      expect(pretty_time(DateTime.new(2012, 5, 6, 13, 33))).to eq 'May 06, 2012  1:33 PM'
+      expect(pretty_time(Time.new(2012, 5, 6, 13, 33))).to eq 'May 06, 2012  1:33 PM'
     end
   end
 

core/spec/helpers/products_helper_spec.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'spec_helper'
 
 module Spree
@@ -14,6 +12,8 @@ module Spree
     end
 
     context '#variant_price_diff' do
+      subject { helper.variant_price(@variant) }
+
       let(:product_price) { 10 }
       let(:variant_price) { 10 }
 
@@ -25,8 +25,6 @@ module Spree
         allow(@variant).to receive(:amount_in) { variant_price }
       end
 
-      subject { helper.variant_price(@variant) }
-
       context 'when variant is same as master' do
         it { is_expected.to be_nil }
       end
@@ -80,7 +78,7 @@ module Spree
       end
 
       context 'when currency is default' do
-        it 'should return the variant price if the price is different than master' do
+        it 'returns the variant price if the price is different than master' do
           product.price = 10
           @variant1.price = 15
           @variant2.price = 20
@@ -101,14 +99,14 @@ module Spree
           end
         end
 
-        it 'should return the variant price if the price is different than master' do
+        it 'returns the variant price if the price is different than master' do
           product.price = 100
           @variant1.price = 150
           expect(helper.variant_price(@variant1)).to eq('¥150')
         end
       end
 
-      it 'should be nil when all variant prices are equal' do
+      it 'is nil when all variant prices are equal' do
         product.price = 10
         @variant1.default_price.update_column(:amount, 10)
         @variant2.default_price.update_column(:amount, 10)
@@ -142,19 +140,19 @@ module Spree
       end
 
       it 'renders a product description without any formatting based on configuration' do
-        initialDescription = %Q{
+        initial_description = %Q{
             <p>hello world</p>
 
             <p>tihs is completely awesome and it works</p>
 
             <p>why so many spaces in the code. and why some more formatting afterwards?</p>
         }
 
-        product.description = initialDescription
+        product.description = initial_description
 
         Spree::Config[:show_raw_product_description] = true
         description = product_description(product)
-        expect(description).to eq(initialDescription)
+        expect(description).to eq(initial_description)
       end
 
       context 'renders a product description default description incase description is blank' do
@@ -166,43 +164,49 @@ module Spree
     shared_examples_for 'line item descriptions' do
       context 'variant has a blank description' do
         let(:description) { nil }
+
         it { is_expected.to eq(Spree.t(:product_has_no_description)) }
       end
       context 'variant has a description' do
         let(:description) { 'test_desc' }
+
         it { is_expected.to eq(description) }
       end
       context 'description has nonbreaking spaces' do
         let(:description) { 'test&nbsp;desc' }
+
         it { is_expected.to eq('test desc') }
       end
       context 'description has line endings' do
         let(:description) { "test\n\r\ndesc" }
+
         it { is_expected.to eq('test desc') }
       end
     end
 
     context '#line_item_description_text' do
       subject { line_item_description_text description }
 
-      it_should_behave_like 'line item descriptions'
+      it_behaves_like 'line item descriptions'
     end
 
     context '#cache_key_for_products' do
+      subject { helper.cache_key_for_products }
+
       let(:zone) { Spree::Zone.new }
       let(:price_options) { { tax_zone: zone } }
 
-      subject { helper.cache_key_for_products }
-      before(:each) do
+      before do
         @products = double('products collection')
-        allow(helper).to receive(:params) { { page: 10 } }
+        allow(helper).to receive(:params).and_return(page: 10)
         allow(helper).to receive(:current_price_options) { price_options }
       end
 
       context 'when there is a maximum updated date' do
         let(:updated_at) { Date.new(2011, 12, 13) }
-        before :each do
-          allow(@products).to receive(:count) { 5 }
+
+        before do
+          allow(@products).to receive(:count).and_return(5)
           allow(@products).to receive(:maximum).with(:updated_at) { updated_at }
         end
 
@@ -211,9 +215,10 @@ module Spree
 
       context 'when there is no considered maximum updated date' do
         let(:today) { Date.new(2013, 12, 11) }
-        before :each do
-          allow(@products).to receive(:count) { 1_234_567 }
-          allow(@products).to receive(:maximum).with(:updated_at) { nil }
+
+        before do
+          allow(@products).to receive(:count).and_return(1_234_567)
+          allow(@products).to receive(:maximum).with(:updated_at).and_return(nil)
           allow(Date).to receive(:today) { today }
         end
 
@@ -222,11 +227,11 @@ module Spree
     end
 
     context '#cache_key_for_product' do
+      subject(:cache_key) { helper.cache_key_for_product(product) }
+
       let(:product) { Spree::Product.new }
       let(:price_options) { { tax_zone: zone } }
 
-      subject(:cache_key) { helper.cache_key_for_product(product) }
-
       before do
         allow(helper).to receive(:current_price_options) { price_options }
       end

core/spec/lib/calculated_adjustments_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Spree::CalculatedAdjustments do
-  it 'should add has_one :calculator relationship' do
+  it 'adds has_one :calculator relationship' do
     assert Spree::ShippingMethod.reflect_on_all_associations(:has_one).map(&:name).include?(:calculator)
   end
 end

core/spec/lib/i18n_spec.rb

@@ -6,15 +6,15 @@
   before do
     I18n.backend.store_translations(:en,
                                                                           spree: {
-                                        foo: 'bar',
-                                        bar: {
-                                          foo: 'bar within bar scope',
-                                          invalid: nil,
-                                          legacy_translation: 'back in the day...'
-                                        },
-                                        invalid: nil,
-                                        legacy_translation: 'back in the day...'
-                                      })
+                                                                            foo: 'bar',
+                                                                            bar: {
+                                                                              foo: 'bar within bar scope',
+                                                                              invalid: nil,
+                                                                              legacy_translation: 'back in the day...'
+                                                                            },
+                                                                            invalid: nil,
+                                                                            legacy_translation: 'back in the day...'
+                                                                          })
   end
 
   it 'translates within the spree scope' do