Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer displays incorrect time during round transition #74

Closed
Aborres opened this issue Mar 31, 2020 · 4 comments
Closed

Timer displays incorrect time during round transition #74

Aborres opened this issue Mar 31, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@Aborres
Copy link

Aborres commented Mar 31, 2020

Hey,

I have been testing the app today for the first time, and it is being great so far (thanks).

However I have noticed this:

Everytime you press play the timer resets to 22:01 before setting its correct time.
When starting a break it resets to -22:01 and then sets itself to whatever you have configured it to do.

image

These are the settings I am using:

image

image

Also, If you accept feedback, it seems like the minimize to tray only works if you restart the app, it would be nice if it were to tell you.

Thanks!

Edit: spelling

@Aborres
Copy link
Author

Aborres commented Mar 31, 2020

Quick Update: the long break one days the same thing but that one turns to -10:01 before setting itself to 15:00

@Splode
Copy link
Owner

Splode commented Mar 31, 2020

Thanks for the detailed issue report @Aborres. I've seen this behavior, too, but haven't tackled it yet. Your documentation of it is helpful, though!

Basically what you're seeing is the difference between the current round time (25) and the next round time (3), which is 22.

Regarding the minimize-to-tray feature, this should happen without having to restart the application, so I think that's a bug. I'll create a separate issue for that based on your findings.

@Splode Splode added the bug Something isn't working label Mar 31, 2020
@Splode Splode changed the title Timer set to 22 when play is clicked Timer displays incorrect time during round transition Apr 1, 2020
@Aborres
Copy link
Author

Aborres commented Apr 1, 2020

No worries, I can't expect you to start debugging it if you can't see the issue for yourself :)

I think I have found a good way to replicate this, If you click on the little arrow to advance the clock while the time is running, the next time to press play it will take the curr time in the clock - the time that had passed in the clock before the click on the arrow.

For example:

Running a 25:00 min long timer.
Click on the arrow at 24:55
3:00 min long break is displayed.
Press play
2:55 min appears for a second and then 3:00 starts the countdown.

@Splode
Copy link
Owner

Splode commented Apr 4, 2020

This issue has been resolved with b7a2419 and is availble on v0.7.1.

Thanks again!

@Splode Splode closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants