Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a bundled version again #61

Open
dmytro-grankin opened this issue Feb 5, 2019 · 0 comments
Open

Publish a bundled version again #61

dmytro-grankin opened this issue Feb 5, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@dmytro-grankin
Copy link
Contributor

dmytro-grankin commented Feb 5, 2019

Since recently, an NPM artifact doesn't provide a bundled version anymore.

It was done since parsing of Protobuf messages wasn't working in the bundled version. The reason is that the import of TypeParsers always references a file from the unbundled version:

// The import generated by Spine's Protobuf Plugin for JS.
let TypeParsers = require('spine-web/client/parser/type-parsers.js').default;

Instead, in pb.js files used in the bundled version should be import TypeParsers from the bundled version too:

// Import `TypeParsers ` from a bundle.
let TypeParsers = require('spine-web/bundle').default;

There is no easy way to adjust these imports depending on the used version (bundled/unbundled). Commonly, the end user can bundle sources on its own, so the absence of the bundled version is not crucial.

After the root issue will be resolved, we should enabled the bundle publishing again, by reverting these changes.

@dmytro-grankin dmytro-grankin added the enhancement New feature or request label Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant