Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Allow customization of HTTP requests sent by the JavaScript client. #189

Open
YegorUdovchenko opened this issue Oct 27, 2022 · 1 comment
Assignees
Labels
Client JS Issues related to the `spine-web-client` library

Comments

@YegorUdovchenko
Copy link
Collaborator

Currently, there's no way to modify requests sent by the Spine Web client for JavaScript to the backend. The common use case is the necessity to attach security headers to all HTTP requests to the backend. To do so in Pure Photos, we initialize the client instance and then replace its internal HttpClient with our custom client that does the same things, but attaches some headers to the requests.

Another thing that is currently not configurable is that the standard HttpClient sends requests in the CORS mode. It may be OK for the most applications but should not be mandatory. Some applications may have the same origin for their frontend/backend and use regular requests in non-CORS mode.

@YegorUdovchenko YegorUdovchenko added the Client JS Issues related to the `spine-web-client` library label Oct 27, 2022
@armiol armiol added this to v1.9 Oct 27, 2022
@armiol armiol moved this to Todo in v1.9 Nov 7, 2022
@armiol armiol changed the title Allow customization of HTTP requests sent by the JavaScript client. [1.x] Allow customization of HTTP requests sent by the JavaScript client. Jan 12, 2023
@armiol
Copy link
Contributor

armiol commented Jan 12, 2023

Addressed via #194.

@armiol armiol moved this from Todo to Done in v1.9 Jan 12, 2023
@armiol armiol self-assigned this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client JS Issues related to the `spine-web-client` library
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants