fix: added a few fixes and type definitions

Author: sksadjad

packages/key-manager/src/agent/SphereonKeyManager.ts

@@ -46,12 +46,13 @@ export class SphereonKeyManager extends VeramoKeyManager {
     throw Error(`KMS ${kms} does not support verification`)
   }
 
-  async keyManagerListKeys({}): Promise<ManagedKeyInfo[]> {
-    const kmsNames = await this.keyManagerGetKeyManagementSystems()
+  async keyManagerListKeys(): Promise<ManagedKeyInfo[]> {
+    const kmsNames: string[] = await this.keyManagerGetKeyManagementSystems()
     const keys: ManagedKeyInfo[] = []
-    for (let i = 0; i < kmsNames.length; i++) {
-      const kms = this.getLocalKms(kmsNames[i])
-      keys.push(...(await kms.listKeys()))
+    for (const kmsName of kmsNames) {
+      const kms: AbstractKeyManagementSystem = this.getLocalKms(kmsName)
+      const keyList: ManagedKeyInfo[] = await kms.listKeys()
+      keys.push(...keyList)
     }
     return keys
   }

packages/key-manager/src/types/ISphereonKeyManager.ts

@@ -17,6 +17,8 @@ export interface ISphereonKeyManager extends IKeyManager, IPluginMethodMap {
    * @param args
    */
   keyManagerVerify(args: ISphereonKeyManagerVerifyArgs): Promise<boolean>
+
+  keyManagerListKeys(): Promise<Array<ManagedKeyInfo>>
 }
 
 /**

packages/kms-local/src/SphereonKeyManagementSystem.ts

@@ -269,7 +269,7 @@ export class SphereonKeyManagementSystem extends KeyManagementSystem {
     return await signer.verify(data, signature)
   }
 
-  public async listKeys(): Promise<ManagedKeyInfo[]> {
-    return (await this.privateKeyStore.list({})).map((privateKey) => this.asSphereonManagedKeyInfo(privateKey))
+  public async listKeys(): Promise<Array<ManagedKeyInfo>> {
+    return (await this.privateKeyStore.list({})).map((privateKey: ManagedPrivateKey) => this.asSphereonManagedKeyInfo(privateKey))
   }
 }