feat: beside the 'with' methods in the builder which will replace exi…

…sting configuration for that field, I've added 'add' methods to add to existing configuration
Sphereon-Opensource · Apr 3, 2023 · 9d42152 · 9d42152
1 parent 38849af
commit 9d42152
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 4 deletions.
diff --git a/packages/issuer/lib/builder/CredentialSupportedV1_11Builder.ts b/packages/issuer/lib/builder/CredentialSupportedV1_11Builder.ts
@@ -28,7 +28,7 @@ export class CredentialSupportedV1_11Builder {
     return this
   }
 
-  withTypes(type: string | string[]): CredentialSupportedV1_11Builder {
+  addTypes(type: string | string[]): CredentialSupportedV1_11Builder {
     if (!Array.isArray(type)) {
       this.types = this.types ? [...this.types, type] : [type]
     } else {
@@ -38,7 +38,13 @@ export class CredentialSupportedV1_11Builder {
     }
     return this
   }
-  withCryptographicBindingMethod(method: string | string[]): CredentialSupportedV1_11Builder {
+
+  withTypes(type: string | string[]): CredentialSupportedV1_11Builder {
+    this.types = Array.isArray(type) ? type : [type]
+    return this
+  }
+
+  addCryptographicBindingMethod(method: string | string[]): CredentialSupportedV1_11Builder {
     if (!Array.isArray(method)) {
       this.cryptographicBindingMethodsSupported = this.cryptographicBindingMethodsSupported
         ? [...this.cryptographicBindingMethodsSupported, method]
@@ -51,7 +57,12 @@ export class CredentialSupportedV1_11Builder {
     return this
   }
 
-  withCryptographicSuitesSupported(suit: string | string[]): CredentialSupportedV1_11Builder {
+  withCryptographicBindingMethod(method: string | string[]): CredentialSupportedV1_11Builder {
+    this.cryptographicBindingMethodsSupported = Array.isArray(method) ? method : [method]
+    return this
+  }
+
+  addCryptographicSuitesSupported(suit: string | string[]): CredentialSupportedV1_11Builder {
     if (!Array.isArray(suit)) {
       this.cryptographicSuitesSupported = this.cryptographicSuitesSupported ? [...this.cryptographicSuitesSupported, suit] : [suit]
     } else {
@@ -60,7 +71,12 @@ export class CredentialSupportedV1_11Builder {
     return this
   }
 
-  withCredentialDisplay(credentialDisplay: Display | Display[]): CredentialSupportedV1_11Builder {
+  withCryptographicSuitesSupported(suit: string | string[]): CredentialSupportedV1_11Builder {
+    this.cryptographicSuitesSupported = Array.isArray(suit) ? suit : [suit]
+    return this
+  }
+
+  addCredentialDisplay(credentialDisplay: Display | Display[]): CredentialSupportedV1_11Builder {
     if (!Array.isArray(credentialDisplay)) {
       this.display = this.display ? [...this.display, credentialDisplay] : [credentialDisplay]
     } else {
@@ -69,6 +85,11 @@ export class CredentialSupportedV1_11Builder {
     return this
   }
 
+  withCredentialDisplay(credentialDisplay: Display | Display[]): CredentialSupportedV1_11Builder {
+    this.display = Array.isArray(credentialDisplay) ? credentialDisplay : [credentialDisplay]
+    return this
+  }
+
   withIssuerCredentialSubjectDisplay(
     subjectProperty: string,
     issuerCredentialSubjectDisplay: IssuerCredentialSubjectDisplay

diff --git a/packages/issuer/lib/builder/VcIssuerBuilder.ts b/packages/issuer/lib/builder/VcIssuerBuilder.ts
@@ -37,6 +37,11 @@ export class VcIssuerBuilder {
   }
 
   public withIssuerDisplay(issuerDisplay: Display[] | Display): VcIssuerBuilder {
+    this.issuerDisplay = Array.isArray(issuerDisplay) ? issuerDisplay : [issuerDisplay]
+    return this
+  }
+
+  public addIssuerDisplay(issuerDisplay: Display[] | Display): VcIssuerBuilder {
     if (!Array.isArray(issuerDisplay)) this.issuerDisplay = this.issuerDisplay ? [...this.issuerDisplay, issuerDisplay] : [issuerDisplay]
     else {
       this.issuerDisplay = this.issuerDisplay ? [...this.issuerDisplay, ...issuerDisplay] : issuerDisplay
@@ -46,6 +51,13 @@ export class VcIssuerBuilder {
 
   public withCredentialsSupported(
     credentialSupported: CredentialIssuerMetadataSupportedCredentials | CredentialIssuerMetadataSupportedCredentials[]
+  ): VcIssuerBuilder {
+    this.credentialsSupported = Array.isArray(credentialSupported) ? credentialSupported : [credentialSupported]
+    return this
+  }
+
+  public addCredentialsSupported(
+    credentialSupported: CredentialIssuerMetadataSupportedCredentials | CredentialIssuerMetadataSupportedCredentials[]
   ): VcIssuerBuilder {
     if (!Array.isArray(credentialSupported))
       this.credentialsSupported = this.credentialsSupported ? [...this.credentialsSupported, credentialSupported] : [credentialSupported]