fix: Fix uri to json conversion when no required params are provided

Sphereon-Opensource · Feb 3, 2024 · 36a70ca · 36a70ca
1 parent 394fcb7
commit 36a70ca
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/common/lib/__tests__/Encoding.spec.ts b/packages/common/lib/__tests__/Encoding.spec.ts
@@ -0,0 +1,15 @@
+import { convertURIToJsonObject } from '../functions';
+
+import { UNIT_TEST_TIMEOUT } from './CredentialOfferUtil.spec';
+
+describe('URI to json enconding', () => {
+  const CREDENTIAL_OFFER_CODE = 'openid-credential-offer://code=1234-1234-1234';
+
+  it(
+    'should get code from auth-code redirect URI',
+    async () => {
+      expect(convertURIToJsonObject(CREDENTIAL_OFFER_CODE)).toEqual({ code: '1234-1234-1234' });
+    },
+    UNIT_TEST_TIMEOUT,
+  );
+});
diff --git a/packages/common/lib/functions/Encoding.ts b/packages/common/lib/functions/Encoding.ts
@@ -88,7 +88,7 @@ export function convertJsonToURI(
  *          - arrayTypeProperties: properties that can show up more that once
  */
 export function convertURIToJsonObject(uri: string, opts?: DecodeURIAsJsonOpts): unknown {
-  if (!uri || !opts?.requiredProperties?.every((p) => uri.includes(p))) {
+  if (!uri || (opts?.requiredProperties && !opts.requiredProperties?.every((p) => uri.includes(p)))) {
     throw new Error(BAD_PARAMS);
   }
   const uriComponents = getURIComponentsAsArray(uri, opts?.arrayTypeProperties);