Nav bar redesign for mobile users #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr-matthews
requested changes
Oct 7, 2023
kr-matthews
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Code looks fine, but I don't want to give an official approval since I can't run it locally to test how it works in practice.
Edit: I'll look into getting the repository running locally at some point, but I'm pretty busy for the next month or so so it might take a while.
JonEsparaz
reviewed
Oct 28, 2023
There was a problem hiding this comment.
Thanks, @mckeenicholas!
I have one final comment, then I'm comfortable merging :)
Tested out using the mobile emulator for a few different devices and I don't see any apparent issues:
Can confirm that the component is key board accessible too, which is great.
JonEsparaz
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Implements a side drawer menu for when the width of the screen shrinks such that it can no longer fit all items along the bottom.