Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home not always highlighted in nav bar #36

Open
kr-matthews opened this issue Mar 4, 2023 · 2 comments
Open

Home not always highlighted in nav bar #36

kr-matthews opened this issue Mar 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working frontend:react

Comments

@kr-matthews
Copy link

If you visit https://www.speedcubingcanada.org/en (or https://www.speedcubingcanada.org/fr) without a trailing / then the home option in the nav bar isn't highlighted. It's only highlighted at https://www.speedcubingcanada.org/en/ (and https://www.speedcubingcanada.org/fr/).
https://www.speedcubingcanada.org/, and any non-existing urls, redirect to the home url without the trailing /, so this comes up a lot.

@JonEsparaz
Copy link
Member

Also, https://www.speedcubingcanada.org/en/organization/ will highlight Home instead of Organization.

Probably worth our first set of unit tests to check this behaviour when a patch is made (can be a separate contribution, I can do the tests myself or provide details on the testing framework).

@JonEsparaz JonEsparaz added the bug Something isn't working label Mar 4, 2023
@JonEsparaz JonEsparaz self-assigned this Apr 26, 2023
@JonEsparaz
Copy link
Member

I'll get this fixed once #54 is merged. Hopefully we can make the localization logic less convoluted overall, but we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend:react
Projects
None yet
Development

No branches or pull requests

2 participants