You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+7-13Lines changed: 7 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,23 +1,16 @@
1
-
<!-- Give your PR a recognizable title. For example: "FE-123: Add new prop to component" or "Resolve Issue #123: Fix bug in component" -->
2
-
<!-- Your PR title will be visible in changelogs -->
1
+
// Give your PR a recognizable title. For example: "FE-123: Add new prop to component" or "Resolve Issue #123: Fix bug in component" // Your PR title will be visible in changelogs
3
2
4
3
### What Changed
5
4
6
-
<!--
7
-
What changes does this PR propose?
8
-
Provide screenshots or [screen recordings](https://getkap.co/) for any visual changes.
9
-
-->
5
+
// What changes does this PR propose? // Provide screenshots or [screen recordings](https://getkap.co/) for any visual changes.
10
6
11
7
### How To Test or Verify
12
8
13
-
<!--
14
-
Describe any steps that may help reviewers verify changes.
15
-
Anything beyond basic unit testing, such as assistive tech usage, or special interactions.
16
-
-->
9
+
// Describe any steps that may help reviewers verify changes. // Anything beyond basic unit testing, such as assistive tech usage, or special interactions.
17
10
18
11
### PR Checklist
19
12
20
-
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are addative to this list depending on what type of PR you are using.
13
+
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.
21
14
22
15
For example: If you are submitting a content change to one of the support documents, your checklist would include the:
23
16
@@ -33,14 +26,15 @@ If you are submitting a feature addition, enhancement, or bug fix, your checklis
33
26
34
27
-[ ] Give your pull request a meaningful name.
35
28
-[ ] Use lowercase filenames.
36
-
-[ ] Pull request approval from #uxfe or #front-end-guild
29
+
-[ ] Pull request approval from the FE team or content experts that isn't the content creator.
37
30
38
31
#### Content Changes Checklist
39
32
40
-
-[ ] Check that your article appears here or in a [Netlify deploy preview](https://app.netlify.com/sites/support-docs/deploys) and looks correct.
33
+
-[ ] Check that your article looks correct in the preview here or in a [Netlify deploy preview](https://app.netlify.com/sites/support-docs/deploys).
41
34
-[ ] Check the links in your article.
42
35
-[ ] Check the images in your article (if there are any)
43
36
-[ ] Check to make sure you are using markdown appropriately as outlined in `examples/article.md` in the root of the project directory and on the momentum doc's [preface article](https://support.sparkpost.com/momentum/4/4-preface)
37
+
-[ ] Check to make sure the [Copy and Tone Guidelines are followed](https://docs.google.com/document/d/1dej9J7N9M8lcbJXnT9kxyNB_EFBPHIBLZBbHaxRWqhQ/edit).
44
38
45
39
#### Development Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")
0 commit comments