Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering BrAPI /allelematrix endpoint data by MAF range and max missing #124

Open
khaled-alshamaa opened this issue May 22, 2024 · 0 comments

Comments

@khaled-alshamaa
Copy link

I would like to see GIGWA supporting all these (optional/extra) minMaf, maxMaf, minMissingData, maxMissingData, minHeZ, and maxHeZ filtering parameters in the allele matrix search call. Just like what they did for the GA4GH /variants/search call.

If we agree on their usefulness from the application point of view, why not suggest having them in the BrAPI /search/allelematrix parameters?

I understand the service provider's argument that such parameters can put a huge computational load on the server side. Well, what will be the alternative option, the client application has nothing but extract the whole dataset, and then do the filtering at their side. This scenario implies more transfer data cost and fewer requests the server can manage because of the transfer time required for each!

I believe adding these filtering parameters can be a win-win situation for both server and client implementation in most production environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant