Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bionic and Artful ubuntu support temporarily solved #1079

Open
Rudy167 opened this issue Aug 6, 2018 · 6 comments
Open

Bionic and Artful ubuntu support temporarily solved #1079

Rudy167 opened this issue Aug 6, 2018 · 6 comments

Comments

@Rudy167
Copy link

Rudy167 commented Aug 6, 2018

I tried installing soundnode on my ubuntu bionic machine but it said package not found, so i tweaked your shell script to identify my distribution as xenial, as you recommended in your script(in the comments),but the music tracks weren't being played.
I have currently tweaked your script (script.deb.sh) so that it identifies if the distribution is artful/bionic and exits the installation with appropriate error message,PFA

script.txt

@jakejarrett
@JonasGroeger

@jakejarrett
Copy link
Member

Are you able to do a PR With the changes? as it looks like the file you linked is on the main soundnode repo?

@Rudy167
Copy link
Author

Rudy167 commented Aug 7, 2018

I would have to upload this script somewhere else and change the URL on the main website to the new location of script,as i do not have the access to the package cloud account where the current script resides,which is
https://packagecloud.io/JonasGroeger/soundnode

This might have performance issues.

@Rudy167
Copy link
Author

Rudy167 commented Aug 7, 2018

@jakejarrett the file is not on the main repo

@jakejarrett
Copy link
Member

Ah thanks, yeah my bad. i looked at the PR when i was super tired.

Yeah the file looks good, I'll try to update the install script if I'm able.

@Rudy167
Copy link
Author

Rudy167 commented Aug 7, 2018

It would be a good idea if you also could add it onto the main repo, for further changes,if any.

@jakejarrett
Copy link
Member

Sorry for delayed response, I might fork the work @JonasGroeger did for CI and setup an automated deployment process where it will output working artifacts that can be used for release binaries.

Regarding the deb/ppa, ideally it should be packaged using snap / appimage / flatpak for the users choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants