Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Store x games in a history? #27

Open
riahc3 opened this issue Jan 17, 2022 · 5 comments
Open

Store x games in a history? #27

riahc3 opened this issue Jan 17, 2022 · 5 comments
Labels
enhancement New feature or request planned Already planned for a later update

Comments

@riahc3
Copy link

riahc3 commented Jan 17, 2022

Hello

AFAIK, Riot's API stores the last 20 or 50 games.

Is it possible for WAIUA to store this info? Maybe it's out of scope but a historial of match details would be nice.

Honestly, I'd like it like tracker.gg that stores all of the match details but I think that is getting side tracked

@Soneliem Soneliem added the enhancement New feature or request label Jan 17, 2022
@Soneliem
Copy link
Owner

Hi again,

The match history thing is something I have planned for a must later update. It will take some time as most of the info I use is from live game endpoints. Therefore some thing will be missing such as skins. In terms of tracker level stats, you are correct in that tracker.gg stores all match history and stats. I cannot do that since:

  1. I don't have the infrastructure to store all that info and earn nothing from WAIUA anyway to support that.
  2. Riot requires info to only be available if the player consents to it. Since I'm not using the official API, I technically don't have to comply to this but for the sake of competitive integrity I have limited the number of things available to view.

I will have a profile page of some sort with personalized stats with the match history as well. That's gonna take some time as that's just a lot of work and I want to learn how to properly implement it first.

@Soneliem Soneliem added the planned Already planned for a later update label Jan 18, 2022
@riahc3
Copy link
Author

riahc3 commented Jan 18, 2022

Thank you for the feedback.

@SaumitraLohokare
Copy link

Hello @Soneliem,
I am not sure what you meant by not having the infrastructure to store all the info. I think that @riahc3 was asking for the application to locally store past matches. Which could be done by storing in a simple file and also we could choose which info to store in the match history to agree with competitive integrity.
Adding GUI to view the match history would be a large task, however storing it in simple text/csv format should be easy. I was wondering if you agree with this? I'd like to work on this if we can figure out the details together.

@Soneliem
Copy link
Owner

Soneliem commented Jun 4, 2022

@SaumitraLohokare I actually discussed this on my server a while back and actually decided that a file based system would actually be a good idea. I've just been busy with waiua 2.0 so I haven't been able to look at it. I'd be happy for you to start working on some sort of system. However i would recommend using the development branch. Additionally I was going to work on player stats during a match using the data from Riot.

I'm still working out things like the mvvm so things are prone to change.

@Soneliem
Copy link
Owner

Soneliem commented Jun 4, 2022

And yes, I think the consensus was maybe json or similar so you can store match info as well as cached overall stats.

@Soneliem Soneliem added this to In progress in WAIUA Project Board Jun 28, 2022
@Soneliem Soneliem moved this from In progress to To do in WAIUA Project Board Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request planned Already planned for a later update
Projects
Development

No branches or pull requests

3 participants