Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader #26

Closed
kjugi opened this issue Oct 30, 2017 · 4 comments
Closed

Add loader #26

kjugi opened this issue Oct 30, 2017 · 4 comments
Assignees

Comments

@kjugi
Copy link
Contributor

kjugi commented Oct 30, 2017

Add loader when clicking on the button or when loading/updating some data.

  • When changing step
  • When loading i.e methods
@kjugi
Copy link
Contributor Author

kjugi commented Nov 8, 2017

Must think about the new method of calling loader. Don't want to manually change this.$store.state.loader each time. Must think about maybe some eventListener on specific elements and toggle this action or sth 🤔

@kjugi
Copy link
Contributor Author

kjugi commented Nov 8, 2017

And think about storing styles. For now, in the BaseLoader component, I have <style> tag.

@szafran89
Copy link
Contributor

Good approach it would be to write mutation setLoading (state, payload) and commit it commit('setLoading', true|false) when you make async requests inside store actions.

@kjugi kjugi self-assigned this Apr 27, 2018
@kjugi
Copy link
Contributor Author

kjugi commented Jul 10, 2018

As I wrote in my first PR to loader in buttons:
If we want to add loader on start than must deal with v-cloak and add some styles to loader

This was referenced Jul 10, 2018
@kjugi kjugi closed this as completed Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants