New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible errors with fd leak detection with gotip (future 1.23) #11

Open

mauri870 opened this issue Jun 15, 2024 · 0 comments

mauri870 commented Jun 15, 2024

I just noticed that there is some fd leak detection logic here:

sneller/cmd/snellerd/run_worker.go

Lines 71 to 78 in 86e9f11

    
           vm.Errorf = logger.Printf 
        
           start := nfds() 
        
           defer func() { 
        
           	http.DefaultClient.CloseIdleConnections() 
        
           	end := nfds() 
        
           	if end > start { 
        
           		logger.Printf("warning: file descriptor leak: exiting with %d > %d", end, start) 
        
           	}

With Go 1.23 this will probably break since it will make use of pidfd on Linux, see https://www.github.com/golang/go/issues/62654.

The fix should be similar to what I submitted to containerd here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment