Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated icons #104

Closed
axieax opened this issue Apr 14, 2023 · 6 comments
Closed

Deprecated icons #104

axieax opened this issue Apr 14, 2023 · 6 comments

Comments

@axieax
Copy link

axieax commented Apr 14, 2023

nerdfix detected the following obsolete or deprecated icons used by nvim-navic. Are there alternatives available, or were these icons taken from elsewhere?

❯ nerdfix check lua/nvim-navic/init.lua
note: Found obsolete icon U+F718
  ┌─ init.lua:9:10
  │
9 │         [1] = " ", -- File
  │                ^ Icon 'nf-mdi-file_document' is marked as obsolete
  │
  = You could replace it with:
        1. 󰈙 U+F0219 nf-md-file_document
        2. 󰷈 U+F0DC8 nf-md-file_document_edit
        3. 󱪗 U+F1A97 nf-md-file_document_alert
        4. 󱪝 U+F1A9D nf-md-file_document_plus

note: Found obsolete icon U+F816
   ┌─ init.lua:11:10
   │
11 │         [3] = " ", -- Namespace
   │                ^ Icon 'nf-mdi-lan' is marked as obsolete
   │
   = You could replace it with:
         1. 󰌗 U+F0317 nf-md-lan
         2. 󰈐 U+F0210 nf-md-fan
         3. 󰮴 U+F0BB4 nf-md-pan
         4. 󰖈 U+F0588 nf-md-wan

note: Found obsolete icon U+F816
   ┌─ init.lua:13:10
   │
13 │         [5] = " ", -- Class
   │                ^ Icon 'nf-mdi-lan' is marked as obsolete
   │
   = You could replace it with:
         1. 󰌗 U+F0317 nf-md-lan
         2. 󰈐 U+F0210 nf-md-fan
         3. 󰮴 U+F0BB4 nf-md-pan
         4. 󰖈 U+F0588 nf-md-wan

note: Found obsolete icon U+F6A6
   ┌─ init.lua:14:10
   │
14 │         [6] = " ", -- Method
   │                ^ Icon 'nf-mdi-cube_outline' is marked as obsolete
   │
   = You could replace it with:
         1. 󰆧 U+F01A7 nf-md-cube_outline
         2. 󱐝 U+F141D nf-md-cube_off_outline
         3. 󱌏 U+F130F nf-md-cup_outline
         4. 󰛐 U+F06D0 nf-md-eye_outline

note: Found obsolete icon U+FA57
   ┌─ init.lua:18:11
   │
18 │         [10] = "練", -- Enum
   │                 ^^ Icon 'nf-mdi-vector_combine' is marked as obsolete
   │
   = You could replace it with:
         1. 󰕘 U+F0558 nf-md-vector_combine
         2. 󰕞 U+F055E nf-md-vector_line
         3. 󰕡 U+F0561 nf-md-vector_polyline
         4. 󰕙 U+F0559 nf-md-vector_curve

note: Found obsolete icon U+FA57
   ┌─ init.lua:19:11
   │
19 │         [11] = "練", -- Interface
   │                 ^^ Icon 'nf-mdi-vector_combine' is marked as obsolete
   │
   = You could replace it with:
         1. 󰕘 U+F0558 nf-md-vector_combine
         2. 󰕞 U+F055E nf-md-vector_line
         3. 󰕡 U+F0561 nf-md-vector_polyline
         4. 󰕙 U+F0559 nf-md-vector_curve

note: Found obsolete icon U+F794
   ┌─ init.lua:20:11
   │
20 │         [12] = " ", -- Function
   │                 ^ Icon 'nf-mdi-function' is marked as obsolete
   │
   = You could replace it with:
         1. 󰊕 U+F0295 nf-md-function
         2. 󱡌 U+F184C nf-md-induction
         3. 󰒉 U+F0489 nf-md-selection
         4. 󰡱 U+F0871 nf-md-function_variant

note: Found obsolete icon U+F6A6
   ┌─ init.lua:21:11
   │
21 │         [13] = " ", -- Variable
   │                 ^ Icon 'nf-mdi-cube_outline' is marked as obsolete
   │
   = You could replace it with:
         1. 󰆧 U+F01A7 nf-md-cube_outline
         2. 󱐝 U+F141D nf-md-cube_off_outline
         3. 󱌏 U+F130F nf-md-cup_outline
         4. 󰛐 U+F06D0 nf-md-eye_outline

note: Found obsolete icon U+F8FE
   ┌─ init.lua:22:11
   │
22 │         [14] = " ", -- Constant
   │                 ^ Icon 'nf-mdi-pi' is marked as obsolete
   │
   = You could replace it with:
         1. 󰏿 U+F03FF nf-md-pi
         2. 󱂛 U+F109B nf-md-api
         3. 󰦙 U+F0999 nf-md-qi
         4.  U+E22C nf-fae-pi

note: Found obsolete icon U+F52B
   ┌─ init.lua:23:11
   │
23 │         [15] = " ", -- String
   │                 ^ Icon 'nf-mdi-alphabetical' is marked as obsolete
   │
   = You could replace it with:
         1. 󰀬 U+F002C nf-md-alphabetical
         2. 󱀌 U+F100C nf-md-alphabetical_off
         3. 󱀍 U+F100D nf-md-alphabetical_variant
         4. 󱀎 U+F100E nf-md-alphabetical_variant_off

note: Found obsolete icon U+F89F
   ┌─ init.lua:24:11
   │
24 │         [16] = " ", -- Number
   │                 ^ Icon 'nf-mdi-numeric' is marked as obsolete
   │
   = You could replace it with:
         1. 󰎠 U+F03A0 nf-md-numeric
         2. 󰬺 U+F0B3A nf-md-numeric_1
         3. 󰬻 U+F0B3B nf-md-numeric_2
         4. 󰬼 U+F0B3C nf-md-numeric_3

note: Found obsolete icon U+F669
   ┌─ init.lua:26:11
   │
26 │         [18] = " ", -- Array
   │                 ^ Icon 'nf-mdi-code_brackets' is marked as obsolete
   │
   = You could replace it with:
         1. 󰅪 U+F016A nf-md-code_brackets
         2. 󰅩 U+F0169 nf-md-code_braces
         3. 󱃖 U+F10D6 nf-md-code_braces_box
         4.  U+E79D nf-dev-brackets

note: Found obsolete icon U+F668
   ┌─ init.lua:27:11
   │
27 │         [19] = " ", -- Object
   │                 ^ Icon 'nf-mdi-code_braces' is marked as obsolete
   │
   = You could replace it with:
         1. 󰅩 U+F0169 nf-md-code_braces
         2. 󱃖 U+F10D6 nf-md-code_braces_box
         3. 󰅪 U+F016A nf-md-code_brackets
         4. 󰞵 U+F07B5 nf-md-cloud_braces

note: Found obsolete icon U+F80A
   ┌─ init.lua:28:11
   │
28 │         [20] = " ", -- Key
   │                 ^ Icon 'nf-mdi-key_variant' is marked as obsolete
   │
   = You could replace it with:
         1. 󰌋 U+F030B nf-md-key_variant
         2. 󱕵 U+F1575 nf-md-key_chain_variant
         3. 󰨶 U+F0A36 nf-md-city_variant
         4. 󰌓 U+F0313 nf-md-keyboard_variant

note: Found obsolete icon U+FCE0
   ┌─ init.lua:29:11
   │
29 │         [21] = "ﳠ ", -- Null
   │                 ^ Icon 'nf-mdi-null' is marked as obsolete
   │
   = You could replace it with:
         1. 󰟢 U+F07E2 nf-md-null
         2. 󰚌 U+F068C nf-md-skull
         3. 󰂚 U+F009A nf-md-bell
         4. 󰐂 U+F0402 nf-md-pill

note: Found obsolete icon U+F816
   ┌─ init.lua:31:11
   │
31 │         [23] = " ", -- Struct
   │                 ^ Icon 'nf-mdi-lan' is marked as obsolete
   │
   = You could replace it with:
         1. 󰌗 U+F0317 nf-md-lan
         2. 󰈐 U+F0210 nf-md-fan
         3. 󰮴 U+F0BB4 nf-md-pan
         4. 󰖈 U+F0588 nf-md-wan

note: Found obsolete icon U+F694
   ┌─ init.lua:33:11
   │
33 │         [25] = " ", -- Operator
   │                 ^ Icon 'nf-mdi-contrast' is marked as obsolete
   │
   = You could replace it with:
         1. 󰆕 U+F0195 nf-md-contrast
         2. 󰆖 U+F0196 nf-md-contrast_box
         3. 󰆗 U+F0197 nf-md-contrast_circle
         4. 󰄘 U+F0118 nf-md-cast

note: Found obsolete icon U+F783
   ┌─ init.lua:34:11
   │
34 │         [26] = " ", -- TypeParameter
   │                 ^ Icon 'nf-mdi-format_text' is marked as obsolete
   │
   = You could replace it with:
         1. 󰊄 U+F0284 nf-md-format_text
         2. 󱉯 U+F126F nf-md-format_list_text
         3. 󰴑 U+F0D11 nf-md-format_textbox
         4. 󰚞 U+F069E nf-md-format_color_text

note: Found obsolete icon U+F767
   ┌─ init.lua:35:12
   │
35 │         [255] = " ", -- Macro
   │                  ^ Icon 'nf-mdi-format_float_left' is marked as obsolete
   │
   = You could replace it with:
         1. 󰉨 U+F0268 nf-md-format_float_left
         2. 󰉪 U+F026A nf-md-format_float_right
         3. 󰉩 U+F0269 nf-md-format_float_none
         4. 󰉧 U+F0267 nf-md-format_float_center
@SmiteshP
Copy link
Owner

What is going to happen to the obsolete icons? Are they going to be removed in newer nerdfonts? The replacement icons suggested are actually smaller in size and don't look as good as the bigger and clearer icons currently being used.

@axieax
Copy link
Author

axieax commented Apr 16, 2023

What is going to happen to the obsolete icons? Are they going to be removed in newer nerdfonts?

Seems like they're likely to be removed soon (I've got a couple of other "obsolete" nerd fonts broken after a recent patched font update).

The replacement icons suggested are actually smaller in size and don't look as good as the bigger and clearer icons currently being used.

Yeah I ran into that when trying to replace the set myself. Hence, I was wondering if you had any other suggestions.

@SmiteshP
Copy link
Owner

Seems like they're likely to be removed soon (I've got a couple of other "obsolete" nerd fonts broken after a recent patched font update).

That is unfortunate.

Yeah I ran into that when trying to replace the set myself. Hence, I was wondering if you had any other suggestions.

I also have no idea what could be done. It is unfortunate that the replacement icons are so tiny. We can add a section about these newer icons in the readme for now, and continue using the better icons as default for most people who don't have issues. Also lets see what other plugins are doing and follow their foots steps, of the top of my head I can think of nvim-compe and nvim-tree also being affected by this issue.

@XenoPhex
Copy link
Contributor

XenoPhex commented May 4, 2023

So I've manually replaced my icon set in the meantime, but for those looking for a fuller list of icons that popular tools are using, feel free to use mine - I updated it recently to utilize the 3.0.0 release: https://github.com/XenoPhex/nvim/blob/42192ef0c637c3ae6e274df4b7b2df633577a72c/lua/utils/icons.lua#L43-L160

@gotgenes
Copy link

gotgenes commented May 4, 2023

Also lets see what other plugins are doing and follow their foots steps, of the top of my head I can think of nvim-compe and nvim-tree also being affected by this issue.

I know lspkind used nerdfix suggestions. onsails/lspkind.nvim#64

I used nerdfix myself last night on my configurations and it was helpful!

@SmiteshP
Copy link
Owner

Closing as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants