Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.2.5 : backward incompatible change in the config #987

Closed
lingwooc opened this issue Jun 27, 2018 · 5 comments
Closed

Magento 2.2.5 : backward incompatible change in the config #987

lingwooc opened this issue Jun 27, 2018 · 5 comments

Comments

@lingwooc
Copy link

You are probably aware of this already but 2.2.5 breaks es.

Preconditions

Magento Version : 2.2.5 CE

ElasticSuite Version : 2.5.12

Environment : Production

Steps to reproduce

  1. Install magento 2.2.5 and elastic suite
  2. Compile

Expected result

  1. Compiles

Actual result

Declaration of Smile\ElasticsuiteCore\Model\ResourceModel\Search\Request\RelevanceConfig::saveConfig($path, $value, $scope, $scopeCode = 'default') 
must be compatible with Magento\Framework\App\Config\ConfigResource\ConfigInterface::saveConfig($path, $value, $scope = Magento\Framework\App\Config\ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeId = 0) 
in /home/jenkins/workspace/MagentoStaging/magento2/shop/vendor/smile/elasticsuite/src/module-elasticsuite-core/Model/ResourceModel/Search/Request/RelevanceConfig.php on line 99

Gotta love breaking changes in minor versions!

@afoucret
Copy link
Contributor

PR #990 should fix the bug and will be part of the next bugfix release (2.5.13).

Thx for reporting.

@mklooss
Copy link

mklooss commented Jun 28, 2018

perfect, running in to the same issue :)

@VincentMarmiesse
Copy link
Contributor

Hi @afoucret,
Do you know the release date of this fix?

@afoucret
Copy link
Contributor

PR have been merged into 2.5.x branch.

The release 2.5.13 will be out when #991 will be fixed.

@afoucret
Copy link
Contributor

It seems there is huge expectations on this .

Just tweeted the release : https://twitter.com/afoucret/status/1012291355056443392

@afoucret afoucret changed the title magento 2.2.5 + latest es stops compilation Magento 2.2.5 : backward incompatible change in the config Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants