Relax name failure handling - other resolvers may be successful

SmartHomeOS · Jul 23, 2024 · 9d96b85 · 9d96b85
1 parent 0803857
commit 9d96b85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/TinyDNS/DNSResolver.cs b/TinyDNS/DNSResolver.cs
@@ -228,7 +228,7 @@ public async Task<List<IPAddress>> ResolveHostV6(string hostname)
                 {
                     //Prevent leaking local domains into the global DNS space
                     if (privateQuery && !IsPrivate(nsIP))
-                        return null;
+                        continue;
 
                     int bytes;
                     try
@@ -262,11 +262,7 @@ public async Task<List<IPAddress>> ResolveHostV6(string hostname)
                     {
                         Message response = new Message(buffer.Slice(0, bytes).Span);
 
-                        //If there is a name error abort and return to the user
-                        if (response.ResponseCode == DNSStatus.NameError)
-                            return response;
-
-                        //For any other error try a different nameserver
+                        //For any error try a different nameserver
                         if (response.ResponseCode != DNSStatus.NoError)
                             continue;
 

diff --git a/TinyDNS/TinyDNS.csproj b/TinyDNS/TinyDNS.csproj
@@ -4,7 +4,7 @@
     <TargetFrameworks>net80</TargetFrameworks>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <Version>0.7</Version>
+    <Version>0.7.1</Version>
     <PackageLicenseExpression>AGPL-3.0-or-later</PackageLicenseExpression>
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <Authors>jdomnitz</Authors>