Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete callback behavior for multiple yepnope calls #96

Closed
meyertee opened this issue Feb 21, 2012 · 1 comment
Closed

Complete callback behavior for multiple yepnope calls #96

meyertee opened this issue Feb 21, 2012 · 1 comment

Comments

@meyertee
Copy link

Hi,

not sure it's a bug, but it seems like a change in behavior of the complete callback.
Previously, when calling yepnope multiple times, like so:

yepnope(['jquery.js', 'other.js']);

// ....later
yepnope({complete:function(){ console.log('lets go!', jQuery) }});

The complete callback in the 2nd call would fire once all files from the 1st call had been downloaded. Now it fires immediately, resulting in jQuery being undefined in the example above.

I also came across this question on stackoverflow, which uses the same technique: http://stackoverflow.com/questions/7344843/yepnopes-complete-callback-question

Unfortunately I can't say when it changed, as I was using the Modernizr packaged version. I can't find out which yepnope version was packed with Modernizr 2.5.1, which used to work for me. Modernizr 2.5.3 and yepnope 1.5.3 are different.

Cheers, Thomas.

@nym
Copy link

nym commented Oct 5, 2012

I have a similar problem related to complete being fired before large js files on slow connections (below 3G basically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants