Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on vulnerable version of nokogiri #363

Closed
gnachman opened this issue Jan 21, 2018 · 2 comments
Closed

Depends on vulnerable version of nokogiri #363

gnachman opened this issue Jan 21, 2018 · 2 comments

Comments

@gnachman
Copy link

Github is warning users about nokogiri < 1.8.1. I got it because I depend on Slather, which specifies

  spec.add_dependency 'nokogiri', '>= 1.6', '< 1.7'

in slather.gemspec.

@ksuther
Copy link
Contributor

ksuther commented Jan 23, 2018

This is necessary so that slather can be installed on vanilla macOS (10.11 and 10.12). When I increased this dependency in the past people started running into trouble. This can change in the future once everyone has had a chance to transition to 10.13 (or 10.14, presumably).

@ksuther
Copy link
Contributor

ksuther commented Feb 8, 2018

Fixed in f986a46

@ksuther ksuther closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants