Skip to content

Conversation

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes an issue with decoding 8-Bit interlaced grayscale images. The offset was not calculated correctly.

Here is an example image:

51a4d21670dc8dfa8ffc9e54afd62f5f

This was decoded as:

output

@brianpopow brianpopow changed the title Fix Decoding 8-Bit grayscale png's with alpha channel Fix Decoding 8-Bit interlaced grayscale png's with alpha channel Feb 4, 2019
@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #830 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
- Coverage   88.74%   88.71%   -0.04%     
==========================================
  Files        1015     1015              
  Lines       44121    44138      +17     
  Branches     3178     3178              
==========================================
+ Hits        39157    39158       +1     
+ Misses       4236     4216      -20     
- Partials      728      764      +36
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...ts/ImageSharp.Tests/Formats/Png/PngDecoderTests.cs 100% <100%> (ø) ⬆️
src/ImageSharp/Formats/Png/PngScanlineProcessor.cs 68.64% <100%> (+5.35%) ⬆️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.34% <0%> (-9.84%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 88.29% <0%> (-5.32%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
.../Processing/Processors/Transforms/CropProcessor.cs 96% <0%> (-4%) ⬇️
...ocessing/Processors/Dithering/ErrorDiffuserBase.cs 93.75% <0%> (-3.13%) ⬇️
...rs/Normalization/HistogramEqualizationProcessor.cs 97.5% <0%> (-2.5%) ⬇️
...eSharp.Tests/IO/DoubleBufferedStreamReaderTests.cs 97.61% <0%> (-2.39%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c48c19...e140646. Read the comment docs.

@JimBobSquarePants
Copy link
Member

@brianpopow Perfect! Thanks very much for this 👍

@JimBobSquarePants JimBobSquarePants merged commit 6a60638 into SixLabors:master Feb 5, 2019
@brianpopow
Copy link
Collaborator Author

@JimBobSquarePants: you are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants