-
-
Notifications
You must be signed in to change notification settings - Fork 887
Don't throw when Position is out of range. #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
======================================
Coverage 87% 87%
======================================
Files 962 962
Lines 51121 51120 -1
Branches 6342 6342
======================================
+ Hits 44925 44928 +3
+ Misses 5148 5145 -3
+ Partials 1048 1047 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I wonder what are detailed semantics for this. For example is it a requirement for stream.Position = long.MaxValue;
Assert.Equal(long.MaxValue, stream.Position); |
That actually throws an I based (copied mostly) the implementation from an old stream in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since we are good enough. Still would be happy if someone clarified (in dotnet/runtime#63040 or somewhere else) what are conformance expectations around the "seeking beyond the length" behavior, but not going to push further to chase the answer.
Prerequisites
Description
According to the docs for Stream.Position
Removing our explicit throw make the implementation compliant. Fix #1903