Skip to content

Remove obsolete PngTextProperties from png metadata #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Remove obsolete PngTextProperties from png metadata #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions src/ImageSharp/Formats/Png/PngMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,34 +91,12 @@ private PngMetadata(PngMetadata other)
public bool HasTransparency { get; set; }

/// <summary>
/// Gets or sets the collection of text data stored within the iTXt, tEXt, and zTXt chunks.
/// Gets or sets the collection of text data stored within the iTXt, tEXt, and zTXt chunks.
/// Used for conveying textual information associated with the image.
/// </summary>
public IList<PngTextData> TextData { get; set; } = new List<PngTextData>();

/// <summary>
/// Gets the list of png text properties for storing meta information about this image.
/// </summary>
public IList<PngTextData> PngTextProperties { get; } = new List<PngTextData>();

/// <inheritdoc/>
public IDeepCloneable DeepClone() => new PngMetadata(this);

internal bool TryGetPngTextProperty(string keyword, out PngTextData result)
{
for (int i = 0; i < this.TextData.Count; i++)
{
if (this.TextData[i].Keyword == keyword)
{
result = this.TextData[i];

return true;
}
}

result = default;

return false;
}
}
}