Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Refactors the IndexedImageFrame<TPixel> to use Buffer2D<byte> internally and the gif decoder/encoder to allow decoding/encoding of large images.

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #1158 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1158   +/-   ##
=======================================
  Coverage   82.26%   82.27%           
=======================================
  Files         681      681           
  Lines       29331    29347   +16     
  Branches     3295     3297    +2     
=======================================
+ Hits        24129    24145   +16     
  Misses       4514     4514           
  Partials      688      688           
Flag Coverage Δ
#unittests 82.27% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...ageSharp/Common/Extensions/ComparableExtensions.cs 64.00% <ø> (ø)
src/ImageSharp/Formats/Gif/GifDecoderCore.cs 83.76% <100.00%> (ø)
src/ImageSharp/Formats/Gif/GifEncoderCore.cs 94.91% <100.00%> (ø)
src/ImageSharp/Formats/Gif/LzwDecoder.cs 95.78% <100.00%> (+0.49%) ⬆️
src/ImageSharp/Formats/Gif/LzwEncoder.cs 98.33% <100.00%> (+0.13%) ⬆️
src/ImageSharp/IndexedImageFrame{TPixel}.cs 100.00% <100.00%> (ø)
...ocessors/Quantization/QuantizeProcessor{TPixel}.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323ddb5...d915f48. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 7c152bb into master Mar 29, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/handle-large-gif branch March 29, 2020 17:44
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants