Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ from E6 template literal gets mistaken for a variable name and reassigned #84

Closed
Siorki opened this issue Sep 24, 2018 · 1 comment
Closed
Assignees

Comments

@Siorki
Copy link
Owner

Siorki commented Sep 24, 2018

The example from #82 contains several string literals ${expression}

If the variable $ is not protected against renaming, the module misinterprets it as a variable and replaces it, yielding a (non-working) result such as H{expression}.

@Siorki
Copy link
Owner Author

Siorki commented Sep 29, 2018

Actually a combination of issues.

Replacement of $ inside strings is fixed since #57.
This was showing up here because of #82 - the strings boundaries were incorrectly computed (yet correctly rearranged afterwards), and the $ got replaced as RegPack believes it was outside of a string. Fix for #82 eliminates the symptom => closing the issue.

@Siorki Siorki closed this as completed Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant