You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the source code for the Eigen Matrix/Tensor library is stored in Code/ThirdParty/eigen. An alternative is to get Eigen during compilation using CMake FetchContent.
We should discuss the pros and cons of this approach. By keeping Eigen in Code/ThirdParty/eigen, we have access to the source code, which could help with debugging and version control, and allow us to optimize the code for our purposes (although this is unlikely). By using FetchContent, we reduce the size of our repo, can more easily upgrade Eigen, and may help with dependency issues.
Solution
Remove Eigen from Code/ThirdParty and get it through CMake using FetchContent.
@aabrown100-git I don't see any reason to use FetchContent besides modernizing our CMake code, will just add more CMake obfuscation.
Using the latest version of software can cause problems that are difficult to track down so we would need to make sure to useGIT_TAG to identify the release.
Also my gut feeling is that this will not work with the current CMake organization and that the build will use the system Eigen installed by VTK. So be sure to test if we are using the local or system Eigen.
Also also FetchContent is inconsistent with the way other external software dependencies in ThirdParty work (e.g. tinyxml). If we use FetchContent for Eigen then need to use it for the other dependencies if we can.
Problem
Currently, the source code for the Eigen Matrix/Tensor library is stored in Code/ThirdParty/eigen. An alternative is to get Eigen during compilation using CMake FetchContent.
We should discuss the pros and cons of this approach. By keeping Eigen in Code/ThirdParty/eigen, we have access to the source code, which could help with debugging and version control, and allow us to optimize the code for our purposes (although this is unlikely). By using FetchContent, we reduce the size of our repo, can more easily upgrade Eigen, and may help with dependency issues.
Solution
Remove Eigen from Code/ThirdParty and get it through CMake using FetchContent.
Additional context
#304
#307
#297
Code of Conduct
The text was updated successfully, but these errors were encountered: