Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Select current transaction set #15

Open
evenprimes opened this issue Jun 23, 2020 · 2 comments
Open

Request: Select current transaction set #15

evenprimes opened this issue Jun 23, 2020 · 2 comments

Comments

@evenprimes
Copy link

Feature request: When inside a transaction set (ST/SE block), the ability to have a command to select that transaction set would be very nice.

Rationale: My EDI development/support team is starting to use VS Code for both trading partner support and test case development. We often deal with files that have dozens to hundreds of transaction sets and having the ability to quickly select one to move/copy into another file would be very handy.

Immediate design challenges:

  1. What should the command do if the cursor is not in an ST/SE block? (Say the ISA segment?) Likely fail with error.
  2. What should the command do if there are multiple cursors? Likely fail with error
  3. What should the command do if the cursor is placed between the segment terminator of the SE segment and the start of an ST segment? Select the NEXT transaction set is my first thought.

I have forked the repo and have started to look at the structure, but I've never developed in TS/JS and I'm new to VS Code, so before I spent too much time/effort I wanted to start a conversation if the idea was likely to be accepted.

@Silvenga
Copy link
Owner

Thanks for taking the time to open a feature request!

Unfortunately, as it currently stands, this extension does not have any semantic knowledge of the EDI specs (e.g. it knows what an ISA segment is, but that's basically it). Mostly because the specs I know of have a proprietary licensed, and inclusion in an Open Source project is legally questionable (e.g. the X12 specs), but also because it's a hard problem to solve without knowing the spec being parsed.

Unfortunately, it's been a couple of years since I've worked with EDI, I'm in a completely different industry now. However, I would welcome any contributions from the community to implement this feature. I would be happy to work with you if you wanted to try to implement it.

@evenprimes
Copy link
Author

Thanks for the feedback on this. I think you might be thinking I'm more ambitious than I really am: I just want to be able to select from the ST down to the SE. Nothing special needed to know (more or less).

But your concern about the license is valid. If the standing meeting is held this fall I'll see if I can grab Steve and ask about that.

I'm going to hack away as/if I have time and if I get something working I'll consider a pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants