-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Auto Confirm For Self-Feedback #3934 #4000
Add: Auto Confirm For Self-Feedback #3934 #4000
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4000 +/- ##
==========================================
+ Coverage 60.72% 60.93% +0.21%
==========================================
Files 73 73
Lines 3320 3315 -5
Branches 475 543 +68
==========================================
+ Hits 2016 2020 +4
+ Misses 1164 1156 -8
+ Partials 140 139 -1
☔ View full report in Codecov by Sentry. |
autogpt/agent/agent.py
Outdated
@@ -87,6 +87,7 @@ def start_interaction_loop(self): | |||
command_name = None | |||
arguments = None | |||
user_input = "" | |||
auto_confirm = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbTrax I am on your branch, running python -m autogpt --debug and I keep typing "s"
And it keeps sending back a very long sentence if it agrees with the next action.
And on top of that it doesn't do the actual action, this means if I keep typing s it will keep doing nothing
Here is what we want:
typing s should do the next action if supervisor agrees, otherwise it should give clear and concise sentence to nudge the agent in the right direction.
Please look at my debug files to see the issue for yourself.
DEBUG.zip
Also you didn't pick the work of @Torantulino in his commit, this commit looks pretty good
@AbTrax I am on your branch, running python -m autogpt --debug and I keep typing "s" Here is what we want: Please look at my debug files to see the issue for yourself. Also you didn't pick the work of @Torantulino in his PR. |
if anybody has got a clever idea how to use self-feedback to tell that we're inside a redundant loop, please speak up, I implemented a crude first stab at #3668 by hashing the response hash (thoughts) in conjunction with the upcoming commands + args (all stringified), and it's working nicely to notice that we're about to do something that we have previously done - but that's obviously not the complete story. We need a way to tell where exactly we're in our top-level plan, to decide if we really want to continue or discard the current iteration. This (PR #3668 ) is just based on hashing full thoughts + new decision (command + args) and incrementing a counter every time we get to see the same "situation": PS: See also: #4129 |
Deployment failed with the following error:
|
Deployment failed with the following error:
|
Background
#3934
Changes
Added Autoconfirm for when self-feedback is used as to #3934
Documentation
Test Plan
PR Quality Checklist