Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate method declaration #2033

Closed
wants to merge 1 commit into from

Conversation

Androbin
Copy link
Contributor

@Androbin Androbin commented Apr 17, 2023

Background

Method declaration "print_assistant_thoughts" is obscured by a declaration of the same name
Method declaration "test_count_message_tokens_invalid_model" is obscured by a declaration of the same name
Method declaration "test_invalid_json_leading_sentence_with_gpt" is obscured by a declaration of the same name
Pylance(reportGeneralTypeIssues)

Changes

Delete obscured method declarations

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@jakubbober
Copy link
Contributor

Hi @Androbin, have you checked that in the test indeed the NotImplementedError is thrown, rather than the KeyError? It's the only difference between the two copies of the function.

@Androbin
Copy link
Contributor Author

@jakubbober The second declaration obscures the first, and all tests pass, therefore the second test passes, and since only one (type of) Exception can be thrown at the same time, the first declaration can be safely deleted.

jakubbober
jakubbober previously approved these changes Apr 17, 2023
@nponeccop nponeccop added the B7 label Apr 17, 2023
@nponeccop nponeccop mentioned this pull request Apr 17, 2023
1 task
@Androbin Androbin requested a review from jakubbober April 19, 2023 01:31
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 24, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 25, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.98 ⚠️

Comparison is base (8670b30) 50.83% compared to head (6135526) 42.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
- Coverage   50.83%   42.86%   -7.98%     
==========================================
  Files          65       65              
  Lines        2935     2935              
  Branches      493      493              
==========================================
- Hits         1492     1258     -234     
- Misses       1319     1615     +296     
+ Partials      124       62      -62     

see 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 28, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@p-i- p-i- removed the B7 label May 16, 2023
@Pwuts
Copy link
Member

Pwuts commented Jun 14, 2023

This has been fixed by now. Thanks for submitting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants