-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete duplicate method declaration #2033
Conversation
Hi @Androbin, have you checked that in the test indeed the |
@jakubbober The second declaration obscures the first, and all tests pass, therefore the second test passes, and since only one (type of) Exception can be thrown at the same time, the first declaration can be safely deleted. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2033 +/- ##
==========================================
- Coverage 50.83% 42.86% -7.98%
==========================================
Files 65 65
Lines 2935 2935
Branches 493 493
==========================================
- Hits 1492 1258 -234
- Misses 1319 1615 +296
+ Partials 124 62 -62 see 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
This has been fixed by now. Thanks for submitting! |
Background
Method declaration
"print_assistant_thoughts"
is obscured by a declaration of the same nameMethod declaration
"test_count_message_tokens_invalid_model"
is obscured by a declaration of the same nameMethod declaration
"test_invalid_json_leading_sentence_with_gpt"
is obscured by a declaration of the same namePylance(reportGeneralTypeIssues)
Changes
Delete obscured method declarations
Documentation
Test Plan
PR Quality Checklist