Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify annotations to future syntax #1968

Merged

Conversation

jayceslesar
Copy link
Contributor

@jayceslesar jayceslesar commented Apr 16, 2023

Background

there were some issues where some modules were using the future syntax without the annotations imported from __future__. This fixes that and ports all type annotations to future syntax and adds the from __future__ import annotations where this future syntax is used to maintain compatibility with older versions of python.

Changes

No functional changes other than removing typing imports in favor of the future syntax and adding the required import to do so on python versions < 3.10

Documentation

No functional changes

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@BillSchumacher
Copy link
Contributor

Thanks for learning me something new today =)

@BillSchumacher BillSchumacher merged commit 5802f17 into Significant-Gravitas:master Apr 16, 2023
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
…e-annotations

unify annotations to future syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants