Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1363 #1903

Closed

Conversation

nobita2041
Copy link

Background

Investigate the missing python executable error reported in #1363,#1896, etc.

Changes.

Correct file path specification.

Test Plan

We have verified that it runs correctly after the modification. Here is the prompt I used

  • Create a python script that outputs "Hello world"
  • Save and run the script file.
  • Save the script file and run it.

Correction of auto_gpt_workspace file paths
Correction of auto_gpt_workspace file paths
@Pwuts
Copy link
Member

Pwuts commented Apr 16, 2023

Neither of the referenced issues will be fixed by this PR, see #1363 (comment) and #1896 (comment).

@Pwuts
Copy link
Member

Pwuts commented Apr 16, 2023

Also conflicts with #1875

@Pwuts
Copy link
Member

Pwuts commented Apr 16, 2023

This PR solves the workspace path issue of execute_shell, although it does not consolidate workspace path resolution across the various commands. I'll try to submit a PR for that separately.

Copy link

@zhayujie zhayujie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to add a parent here, otherwise the path of worksapce is autogpt/auto_gpt_workspace.

@nponeccop
Copy link
Contributor

@nobita2041 There are conflicts now. We merged another PR fixing the same issue, so think if you have anything to add, and if not, close this one.

@p-i-
Copy link
Contributor

p-i- commented Apr 16, 2023

Closing as fixed by #1947

@p-i- p-i- closed this Apr 16, 2023
@nponeccop nponeccop mentioned this pull request Apr 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants