Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate test_input and test_output in block tests #8719

Open
Pwuts opened this issue Nov 19, 2024 — with Linear · 0 comments
Open

Validate test_input and test_output in block tests #8719

Pwuts opened this issue Nov 19, 2024 — with Linear · 0 comments

Comments

Copy link
Member

Pwuts commented Nov 19, 2024

Original comment: #8358 (comment)

backend/test/block/test_block.py -> test_available_blocks relies entirely on block.test_output to verify that a block works. Leaving test_output empty will let the tests always pass. To address this, test_available_blocks should validate test_input and test_output using block.input_schema and block.output_schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant