Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dx: Fix pre-commit config #8584

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

dx: Fix pre-commit config #8584

wants to merge 8 commits into from
+190 −34

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 7, 2024 •
edited
Loading

The pre-commit config was never updated properly for the new AutoGPT Platform codebase. This PR adds checks for the backend and autogpt_libs, and fixes some of the checks for the classic projects.

What this PR does not do

  • Add linting/formatting/type checking for autogpt_platform/frontend/
    ... because I don't know the state of linting/typechecking setup for the frontend.
  • Unify linting/formatting from ruff + isort + black -> ruff
    ... to keep this PR simple.

Changes 🏗️

  • fix naming of hooks
  • fix pyright hooks (b0rked by repo restructure)
  • fix forge path (b0rked by faulty replace-all when the repo was restructured)
  • fix black hook to work on all Python versions
  • add poetry install hooks
  • add ruff, isort, pyright, pytest, and prisma generate hooks for backend/
  • add ruff and pyright hooks for autogpt_libs/

@Pwuts Pwuts requested review from a team as code owners November 7, 2024 20:25
@Pwuts Pwuts requested review from Swiftyos and majdyz and removed request for a team November 7, 2024 20:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This PR targets the master branch but does not come from dev or a hotfix/* branch.

Automatically setting the base branch to dev.

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end platform/blocks labels Nov 7, 2024
@github-actions github-actions bot changed the base branch from master to dev November 7, 2024 20:25
@github-actions github-actions bot added conflicts Automatically applied to PRs with merge conflicts size/l labels Nov 7, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 86212ee
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/672d22229713af0008dd1aca

@Pwuts Pwuts removed the conflicts Automatically applied to PRs with merge conflicts label Nov 7, 2024
@Significant-Gravitas Significant-Gravitas deleted a comment from github-actions bot Nov 7, 2024
@Significant-Gravitas Significant-Gravitas deleted a comment from github-actions bot Nov 7, 2024
@Pwuts Pwuts enabled auto-merge (squash) November 7, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftyos Swiftyos Awaiting requested review from Swiftyos Swiftyos is a code owner automatically assigned from Significant-Gravitas/maintainers

@majdyz majdyz Awaiting requested review from majdyz majdyz is a code owner automatically assigned from Significant-Gravitas/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/blocks platform/frontend AutoGPT Platform - Front end size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix pre-commit config
1 participant
@Pwuts