Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse website should use VCR #4496

Closed
1 task done
waynehamadi opened this issue May 31, 2023 · 2 comments
Closed
1 task done

Browse website should use VCR #4496

waynehamadi opened this issue May 31, 2023 · 2 comments
Labels

Comments

@waynehamadi
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Summary 💡

VCR records http interactions. One of these http interactions is to browse a website based on an arbitrary url.

Since we whitelist urls, (meaning we give the list of allowed urls, not the list of unallowed ones), it's impossible to cover all the cases, because there is probably more than a billion urls possible.

This means VCR currently doesn't support browse website.
The solution might be to have a blacklist approach instead of whitelist.

Examples 🌈

No response

Motivation 🔦

No response

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This issue has automatically been marked as stale because it has not had any activity in the last 50 days. You can unstale it by commenting or removing the label. Otherwise, this issue will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 6, 2023
@github-actions
Copy link
Contributor

This issue was closed automatically because it has been stale for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant