Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a solution to make isort and black NOT slow down challenge contribution #4163

Closed
1 task done
waynehamadi opened this issue May 13, 2023 · 3 comments
Closed
1 task done

Find a solution to make isort and black NOT slow down challenge contribution #4163

waynehamadi opened this issue May 13, 2023 · 3 comments
Labels
challenge ci

Comments

@waynehamadi
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Summary 💡

As people try to beat challenges, we don't want them to waste time on these linters, I think the current CI pipeline could be slightly improved to achieve this:

  • We still want clean code merged to master where black and isort has ran.
  • We don't want someone to change a prompt, try our challenges and then he realizes he has to run black and isort to actually get the results of his benchmarks.

Examples 🌈

No response

Motivation 🔦

No response
@waynehamadi waynehamadi mentioned this issue May 13, 2023
Closed
@Boostrix
Copy link
Contributor

agreed, exclude some folders ?

@ntindle
Copy link
Member

ntindle commented May 14, 2023

Not sure about this one

@Boostrix Boostrix added the ci label May 16, 2023
@waynehamadi
Copy link
Contributor Author

the challenges are not slowed down by the linter github workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
challenge ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ntindle @waynehamadi @samuelbutler @Boostrix