Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements to DBC extraction #978

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

johnnylam88
Copy link
Contributor

  • Allow for skipping the use of a Python process to create
    SpellShapeshift.csv.

  • Automatically detect the latest versions of the WoW build
    directories from CASC and DBC extraction processes when creating
    src/utils/importsimc/types.ts.

* Allow for skipping the use of a Python process to create
  SpellShapeshift.csv.

* Automatically detect the latest versions of the WoW build
  directories from CASC and DBC extraction processes when creating
  `src/utils/importsimc/types.ts`.
@johnnylam88
Copy link
Contributor Author

This commit just completes a TODO within the dbc.ts file, and also allows me to skip running the python script because it doesn't work within my Cygwin setup.

@Sidoine Sidoine merged commit fcccfe0 into Sidoine:master Aug 30, 2021
@johnnylam88 johnnylam88 deleted the feat/dbc branch August 30, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants