Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing schema check for theme app extension #613

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

AribaRajput
Copy link
Contributor

@AribaRajput AribaRajput commented Nov 20, 2024

What are you adding in this PR?

cc (collab): @itsjustriley

Closes #402.

Shopify dev docs PR: https://github.com/Shopify/shopify-dev/pull/50817

Adds a theme check on theme app extensions for missing schema.

What's next? Any followup issues?

No followup issues.

What did you learn?

Cannot pass context into codePathStart() or codePathEnd(). Theme app extensions cannot currently be tophatted in Horizon.

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@AribaRajput AribaRajput marked this pull request as draft November 20, 2024 19:03
@AribaRajput AribaRajput force-pushed the ariba-riley/add-missing-schema-check branch 3 times, most recently from a01a22a to 4a6f072 Compare November 20, 2024 20:59
@AribaRajput AribaRajput marked this pull request as ready for review November 20, 2024 21:00
@AribaRajput AribaRajput force-pushed the ariba-riley/add-missing-schema-check branch from 4a6f072 to a82deca Compare November 20, 2024 21:08
@AribaRajput AribaRajput requested a review from aswamy November 20, 2024 21:09
@AribaRajput AribaRajput force-pushed the ariba-riley/add-missing-schema-check branch from a82deca to 7988de1 Compare November 20, 2024 21:18
@AribaRajput AribaRajput force-pushed the ariba-riley/add-missing-schema-check branch from 7988de1 to 05ae5ea Compare November 20, 2024 21:19
Copy link
Contributor

@charlespwd charlespwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 LGTM! Let's go!

{% endfor %}
</footer>

{% schema %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AribaRajput
Copy link
Contributor Author

/shipit

@AribaRajput AribaRajput merged commit e0cfd31 into main Nov 22, 2024
6 checks passed
@AribaRajput AribaRajput deleted the ariba-riley/add-missing-schema-check branch November 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme Check must report the absence of schema on theme app extension blocks
3 participants