Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

New starter templates for Vue and React #913

Open
liron-navon opened this issue Dec 13, 2018 · 5 comments
Open

New starter templates for Vue and React #913

liron-navon opened this issue Dec 13, 2018 · 5 comments

Comments

@liron-navon
Copy link

liron-navon commented Dec 13, 2018

help required!

I need help to get the template in the wiki, unfortunately this has to be made by one of the official maintainers, I can't create a pull request =(.

contribution

I created two new starter templates which extend the shopify/skeleton-theme, One for React and one for Vue.
None of them are SPA directed, and should work properly for creating components in the existing .liquid templates.

liron-navon/slate-vue-starter
liron-navon/slate-react-starter

@t-kelly
Copy link
Contributor

t-kelly commented Dec 13, 2018

@liron-navon we're in the process of replacing the docs so the community can make PRs on it. Could you branch off of add-docasaurus make the edits there and open a PR?

@t-kelly
Copy link
Contributor

t-kelly commented Dec 13, 2018

Will give these starter themes a review!

@liron-navon
Copy link
Author

liron-navon commented Dec 13, 2018

@t-kelly

I added the changes here #914.

@t-kelly
Copy link
Contributor

t-kelly commented Dec 13, 2018

Related #871

@robmellett
Copy link

robmellett commented Feb 24, 2019

@liron-navon

Hey mate, I had a couple of issues getting the Vue dev tools to work using your theme. I've modified it slightly so that we load the Vue ESM, and that it supports loading elements in the following manner as opposed to the vueMount helper.

Register new Vue Components in vue/app.js

Vue.component('example-component', require('./components/ExampleComponent.vue').default);

Throughout the liquid files, you should be able to render the vue templates with:

<example-component
    shopName="{{ shop.name }}"></example-component>

See the following changes in this repo.
https://github.com/robmellett/slate-vue-starter

Thanks for doing all the leg work @liron-navon :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants